Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #28695 to 8.1: [filebeat][httpjson] Set url as a pointer to ensure access to all methods #30575

Closed
wants to merge 1 commit into from
Closed

Cherry-pick #28695 to 8.1: [filebeat][httpjson] Set url as a pointer to ensure access to all methods #30575

wants to merge 1 commit into from

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Feb 24, 2022 •
edited by zube bot
Loading

Cherry-pick of PR #28695 to 8.1 branch. Original message:

What does this PR do?

Change how url is stored in the request context, from value to pointer.

Why is it important?

In templates methods with a pointer receiver are not available if the variable is passed by value, making access to .url.Query and others impossible.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr
[filebeat][httpjson] Set url as a pointer to ensure access to all met…
316352f 
…hods (elastic#28695)

* Set url as a pointer to ensure access to all methods

* Add changelog line

* Fix text

(cherry picked from commit 47dba85)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 24, 2022
@marc-gr marc-gr closed this Feb 24, 2022
@marc-gr marc-gr deleted the backport_28695_8.1 branch February 24, 2022 12:01
@zube zube bot assigned marc-gr and unassigned marc-gr Feb 24, 2022
@zube zube bot removed the [zube]: Done label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marc-gr marc-gr

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc-gr @elasticmachine