-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filesystem and fsstat docs to update the definition of a "file" #30631
Update filesystem and fsstat docs to update the definition of a "file" #30631
Conversation
This reverts commit 3550969.
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
NOTE: |
The other option here would be to have the metrics actually report the number of files instead of inodes, and add new metrics for inodes. I don't think this affects correcting the documentation, but should we have an issue to consider doing that? |
@cmacknz so, there's no good, OS-independent, filesystem-independent way to get the number of files. Doing something equivalent |
Thanks, that makes sense. If you are updating the code comments can you add this explanation there as well? That will save the next person trying to understand this some time. |
@fearful-symmetry , I'm afraid the backport-v8.2.0 is not yet available, and likely it points to main since main is 8.2 based. What branch would you need to backport this particular PR to? The backport definitions can be found in https://github.com/elastic/beats/blob/main/.mergify.yml#L210-L248 |
@v1v so, I actually assumed it would be in 8.2, I think I just keep adding the backport label out of habit, since that's a little closer to how the backports worked pre 8.0. |
What does this PR do?
I recently realized that what the
system/fsstat
andsystem/filesystem
callsfiles
are in fact inodes. A lot of users might not even notice the difference, as the total count of files and used inodes can be fairly similar, but I figured it was at least worth updating the docs for anything that decides to dig deeper. It would be nice to update the fields themselves to be*.inodes
where appropriate, but we can't really do that without breaking existing mappings, and aliasing the fields seems confusing in its own right, asfiles
andinodes
are conceptually rather different.Why is it important?
This is a doc change that more accurately describes what some of the fields actually mean.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.