Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing info log #30971

Merged
merged 12 commits into from
Apr 13, 2022
Merged

removing info log #30971

merged 12 commits into from
Apr 13, 2022

Conversation

solrac97gr
Copy link
Contributor

What does this PR do?

Remove the info log, because this were generating unnecessary logs.

Why is it important?

That generate a big number of log who can distract of the real problem.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Check if it's also convenient just change the info to debug log

How to test this PR locally

check in the watch logs there is not showing the "Start Next Scan" log

Related issues

Use cases

Scenario: Your Watch get a Event
When the Watcher have new Event
Then the Watcher will not create a log with "Start Next Scan" in every event

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 23, 2022
@cla-checker-service
Copy link

cla-checker-service bot commented Mar 23, 2022 •
edited
Loading

💚 CLA has been signed

@mergify
Copy link
Contributor

mergify bot commented Mar 23, 2022

This pull request does not have a backport label. Could you fix it @solrac97gr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 23, 2022
@solrac97gr
Copy link
Contributor Author

I already sign the Licence

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 23, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-13T13:21:44.718+0000

  • Duration: 65 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 6200
Skipped 728
Total 6928

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jlind23 jlind23 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 30, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 30, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@jlind23
Copy link
Collaborator

jlind23 commented Mar 30, 2022

/test

@cmacknz cmacknz requested a review from kvch March 30, 2022 13:29
@jlind23 jlind23 requested a review from a team March 30, 2022 14:19
@cmacknz
Copy link
Member

cmacknz commented Mar 30, 2022

I already sign the Licence

@solrac97gr I checked I see the license signed with the hotmail address in your github profile, but the email for the commit is a gmail address. The CLA is looking at the commit email, not the PR. Either signing the CLA with your the gmail address in the commit or changing the commit to use your hotmail address will fix the check.

kvch
kvch suggested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@kvch kvch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not remove this log message. It has helped me on many occasions to track down issues. Instead decrease the log level to debug.

@solrac97gr
Copy link
Contributor Author

@cmacknz changing no problem

solrac97gr and others added 9 commits March 31, 2022 14:36
@solrac97gr
removing info log
c736be4
@solrac97gr
Merge branch 'I30394-removing-console-log' of github.com:solrac97gr/b…
eb20c5d 
…eats into I30394-removing-console-log
@AndersonQ @solrac97gr
build and package the beats for darwin/arm64 (#29585)
13bcd35 
* build and packages beats for darwin/arm64. The tar.gz package is called darwin-aarch64

* Osquerybeat: Add darwin/arm64 packaging support (#30935)

Co-authored-by: Aleksandr Maus <[email protected]>

removing info log

removing info log
@solrac97gr
Merge branch 'I30394-removing-console-log' of github.com:solrac97gr/b…
d004242 
…eats into I30394-removing-console-log
@solrac97gr
removing info log
b3f83d1
@solrac97gr
Revert "removing info log"
1a1266b 
This reverts commit aa7065a.
@solrac97gr
Merge branch 'I30394-removing-console-log' of github.com:solrac97gr/b…
dde36eb 
…eats into I30394-removing-console-log
@solrac97gr
Deleting log
ab3db77
@solrac97gr
Merge branch 'I30394-removing-console-log' of github.com:solrac97gr/b…
95f1817 
…eats into I30394-removing-console-log
@solrac97gr
Copy link
Contributor Author

already try changing mail and signin with both mails but not result

@cmacknz cmacknz requested a review from kvch April 11, 2022 13:49
@cmacknz
Copy link
Member

cmacknz commented Apr 11, 2022

already try changing mail and signin with both mails but not result

I had to re-trigger the verification. It is signed now, and the CI checks can continue.

@cmacknz
Copy link
Member

cmacknz commented Apr 12, 2022

/test

kvch
kvch approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@kvch kvch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@jlind23
Copy link
Collaborator

jlind23 commented Apr 13, 2022

/test

@cmacknz cmacknz merged commit 5478d73 into elastic:main Apr 13, 2022
v1v added a commit to v1v/beats that referenced this pull request Apr 18, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/rename-dock…
eda0443 
…er-tar-gz

* upstream/main: (139 commits)
  [Automation] Update elastic stack version to 8.3.0-c655cda8 for testing (elastic#31322)
  Define a queue metrics reporter interface  (elastic#31289)
  [Oracle Module] Change tablespace metricset collection period (elastic#31259)
  libbeat/reader/syslog: relax timestamp parsing to allow leading zero (elastic#31254)
  [Automation] Update elastic stack version to 8.3.0-55ba6f37 for testing (elastic#31311)
  [libbeat] Remove unused fields and functions in the memory queue (elastic#31302)
  [libbeat] Cleaning up some unneeded helper types (elastic#31290)
  Readme for kibana module (elastic#31276)
  [Automation] Update elastic stack version to 8.3.0-4be61f32 for testing (elastic#31296)
  x-pack/winlogbeat/module/routing/ingest: fix typo for channel name (elastic#31291)
  Small pipeline cleanup removing some unused data fields (elastic#31288)
  removing info log (elastic#30971)
  Simplify TLS config deserialization (elastic#31168)
  Detect new files under known paths in filestream input (elastic#31268)
  Add support for port mapping in docker hints (elastic#31243)
  Update qa-labels.yml (elastic#31260)
  libbeat: log debug for `proxy_url` and fixed docs (elastic#31130)
  [heartbeat][docs] Add note about ensuring correct index settings for uptime (elastic#31146)
  [Automation] Update elastic stack version to 8.3.0-2c8f9574 for testing (elastic#31256)
  [Filebeat] fix m365_defender pipeline bug (elastic#31227)
  ...
kush-elastic pushed a commit to kush-elastic/beats that referenced this pull request May 2, 2022
@solrac97gr @cmacknz @kush-elastic
removing info log (elastic#30971)
aee0902 
Log start of filestream scan at debug level

Co-authored-by: carlos97gr <[email protected]>
Co-authored-by: Craig MacKenzie <[email protected]>
@zhiweiv
Copy link

zhiweiv commented Jul 7, 2022 •
edited
Loading

Is it possible backport this change to 7.17? We will stay at 7.17 for a long time.

@cmacknz cmacknz added the backport-7.17 Automated backport to the 7.17 branch with mergify label Jul 7, 2022
@mergify mergify bot mentioned this pull request Jul 7, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 7, 2022
@solrac97gr @mergify
removing info log (#30971)
15aaf92 
Log start of filestream scan at debug level

Co-authored-by: carlos97gr <[email protected]>
Co-authored-by: Craig MacKenzie <[email protected]>
(cherry picked from commit 5478d73)
@cmacknz
Copy link
Member

cmacknz commented Jul 7, 2022

@zhiweiv 7.17 cherry pick is here: #32252, it will be a part of the next 7.17 patch release.

cmacknz pushed a commit that referenced this pull request Jul 11, 2022
@mergify @solrac97gr
removing info log (#30971) (#32252)
4ff9ead 
Log start of filestream scan at debug level

Co-authored-by: carlos97gr <[email protected]>
Co-authored-by: Craig MacKenzie <[email protected]>
(cherry picked from commit 5478d73)

Co-authored-by: Carlos García Rosales <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@solrac97gr @cmacknz @chrisberkhout
removing info log (#30971)
c28e4f2 
Log start of filestream scan at debug level

Co-authored-by: carlos97gr <[email protected]>
Co-authored-by: Craig MacKenzie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz cmacknz approved these changes

@kvch kvch kvch approved these changes

Assignees

@solrac97gr solrac97gr

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat] Reduce useless console log in filestream input
7 participants
@solrac97gr @elasticmachine @jlind23 @cmacknz @zhiweiv @kvch @AndersonQ