Rename lint stage to checks on the CI
#31110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we introduced the linter and the Github action this naming started causing some confusion. Now it's more obvious where the actual linting takes place and where we have just additional checks.
rdner
added
enhancement
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
added
needs_team
cmacknz
approved these changes
Apr 1, 2022
ruflin
approved these changes
Apr 1, 2022
❕ Build Aborted
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Tests are still failing for all builds after 40eeef4 I'm trying to find out how to fix them. |
|
@rdner it looks like |
6 tasks
|
@oren-zohar thanks for pointing this out. I've fixed it. |
jlind23
pushed a commit
that referenced
this pull request
Apr 4, 2022
Since we introduced the linter and the Github action this naming started causing some confusion. Now it's more obvious where the actual linting takes place and where we have just additional checks. Remove deprecation message Remove functionbeat log message Functionbeat is definitely not going to be deprecated in 8.1, removing this comment. Update root.go Update functionbeat.go
emilioalvap
pushed a commit
to emilioalvap/beats
that referenced
this pull request
Apr 6, 2022
Since we introduced the linter and the Github action this naming started causing some confusion. Now it's more obvious where the actual linting takes place and where we have just additional checks.
kush-elastic
pushed a commit
to kush-elastic/beats
that referenced
this pull request
May 2, 2022
Since we introduced the linter and the Github action this naming started causing some confusion. Now it's more obvious where the actual linting takes place and where we have just additional checks.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Since we introduced the linter and the Github action this naming started causing some confusion. Now it's more obvious where the actual linting takes place and where we have just additional checks. Remove deprecation message Remove functionbeat log message Functionbeat is definitely not going to be deprecated in 8.1, removing this comment. Update root.go Update functionbeat.go
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since we introduced the linter and the Github action this naming started
causing some confusion. Now it's more obvious where the actual linting
takes place and where we have just additional checks.
Why is it important?
We already had a discussion regarding this confusion with @ruflin in #31098