-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove libbeat/common/transport/httpcommon
and libbeat/common/transport/tlscommon
#31579
Conversation
This pull request is now in conflicts. Could you fix it? 🙏
|
libbeat/common/transport/httpcommon
and libbeat/common/transport/tlscommon
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still waiting for the build to finish but all changes make sense to me.
…sport/tlscommon` (#31579)
What does this PR do?
This PR removes the following packages:
github.com/elastic/beats/v7/libbeat/common/transport/httpcommon
github.com/elastic/beats/v7/libbeat/common/transport/tlscommon
I am not fixing linter issues.
Why is it important?
Avoid maintaining the same code in two places.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.