Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libbeat/common/transport/httpcommon and libbeat/common/transport/tlscommon #31579

Merged
merged 4 commits into from
May 17, 2022

Conversation

kvch
Copy link
Contributor

@kvch kvch commented May 10, 2022

What does this PR do?

This PR removes the following packages:

  • github.com/elastic/beats/v7/libbeat/common/transport/httpcommon
  • github.com/elastic/beats/v7/libbeat/common/transport/tlscommon

I am not fixing linter issues.

Why is it important?

Avoid maintaining the same code in two places.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 10, 2022
@mergify mergify bot assigned kvch May 10, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 10, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-16T14:03:09.708+0000

  • Duration: 142 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 24785
Skipped 2146
Total 26931

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kvch kvch force-pushed the move-transport branch from 2b2021a to 7b5c1d2 Compare May 10, 2022 17:48
@mergify
Copy link
Contributor

mergify bot commented May 12, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b move-transport upstream/move-transport
git merge upstream/main
git push upstream move-transport

@kvch kvch changed the title remove transport/httpcommon and transport/tlscommon Remove libbeat/common/transport/httpcommon and libbeat/common/transport/tlscommon May 16, 2022
@kvch kvch added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label May 16, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 16, 2022
@kvch kvch marked this pull request as ready for review May 16, 2022 14:52
@kvch kvch requested review from a team as code owners May 16, 2022 14:52
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@kvch kvch requested review from rdner and fearful-symmetry and removed request for a team May 16, 2022 14:52
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting for the build to finish but all changes make sense to me.

@kvch kvch merged commit 5129d6c into elastic:main May 17, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants