fix: use multiarch ARM Docker images on any architecture #31779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
kuisathaverat
added
ci
Team:Automation
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
/package |
1 similar comment
|
/package |
|
This requires Go 1.18.2, the main branch is still on 1.17.10 |
|
/test |
kuisathaverat
requested review from
rdner and
fearful-symmetry
and removed request for
a team
|
/test |
rdner
approved these changes
Jun 1, 2022
mdelapenya
approved these changes
Jun 1, 2022
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 3, 2022
(cherry picked from commit 7509551)
zmoog
pushed a commit
that referenced
this pull request
Jun 28, 2022
(cherry picked from commit 7509551)
kuisathaverat
added a commit
that referenced
this pull request
Jun 28, 2022
…1819) (cherry picked from commit 7509551) Co-authored-by: Ivan Fernandez Calvo <[email protected]>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove a workaround added to force to use ARM Docker images on ARM architectures to build ARM binaries.
Why is it important?
This workaround is no longer need on the golang-crossbuild Docker images, we publish multiarch Docker images for the arm flavor.
Checklist
[] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
on an ARM64 machine run the command
PLATFORMS="linux/arm64" mage packageon any beat.Related issues
Use cases
Screenshots
Logs