-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heartbeat] Fix enabled flag usage in case of streams #33293
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/uptime (Team:Uptime) |
This pull request doesn't have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but needs a unit test. Can you add it? If not, I can submit one, just let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now that there's a unit test and Changelog
Fixes usage of Enabled incase of data streams Fixes #33270 (cherry picked from commit 7bddf80) Co-authored-by: Shahzad <[email protected]>
Fixes usage of Enabled incase of data streams Fixes #33270
Fixes usage of Enabled incase of data streams !!
Fix #33270
Example to test