Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.4](backport #33655) [metricbeat] [gcp] remove compute metadata cache #33949

Closed
wants to merge 1 commit into from
Closed

[8.4](backport #33655) [metricbeat] [gcp] remove compute metadata cache #33949

wants to merge 1 commit into from
+55 −24

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 5, 2022 •
edited by zube bot
Loading

This is an automatic backport of pull request #33655 done by Mergify.
Cherry-pick of 74edd05 has failed:

On branch mergify/bp/8.4/pr-33655
Your branch is up to date with 'origin/8.4'.

You are currently cherry-picking commit 74edd05ef4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc
	modified:   x-pack/metricbeat/module/gcp/metrics/compute/metadata_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/metricbeat/module/gcp/metrics/compute/metadata.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@gpop63 @mergify
[metricbeat] [gcp] remove compute metadata cache (#33655)
cf8c9be 
* remove compute metadata cache

* add logs and change map key type

* add import aliases

* add changelog entry

* cleanup comments

* remove comments

(cherry picked from commit 74edd05)

# Conflicts:
#	x-pack/metricbeat/module/gcp/metrics/compute/metadata.go
@mergify mergify bot requested a review from a team as a code owner December 5, 2022 20:46
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Dec 5, 2022
@mergify mergify bot assigned gpop63 Dec 5, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 5, 2022
@botelastic
Copy link

botelastic bot commented Dec 5, 2022

This pull request doesn't have a Team:<team> label.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@elasticmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-05T20:47:01.691+0000

  • Duration: 23 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

Steps errors 16

Expand to view the steps failures

Show only the first 10 steps failures

x-pack/metricbeat-pythonIntegTest - mage pythonIntegTest
  • Took 2 min 7 sec . View more details here
  • Description: mage pythonIntegTest
x-pack/metricbeat-pythonIntegTest - mage pythonIntegTest
  • Took 1 min 32 sec . View more details here
  • Description: mage pythonIntegTest
x-pack/metricbeat-pythonIntegTest - mage pythonIntegTest
  • Took 1 min 32 sec . View more details here
  • Description: mage pythonIntegTest
x-pack/metricbeat-windows-2022-windows-2022 - mage build unitTest
  • Took 0 min 9 sec . View more details here
  • Description: mage build unitTest
x-pack/metricbeat-windows-2022-windows-2022 - mage build unitTest
  • Took 0 min 7 sec . View more details here
  • Description: mage build unitTest
x-pack/metricbeat-windows-2022-windows-2022 - mage build unitTest
  • Took 0 min 9 sec . View more details here
  • Description: mage build unitTest
x-pack/metricbeat-windows-2016-windows-2016 - mage build unitTest
  • Took 0 min 12 sec . View more details here
  • Description: mage build unitTest
x-pack/metricbeat-windows-2016-windows-2016 - mage build unitTest
  • Took 0 min 9 sec . View more details here
  • Description: mage build unitTest
x-pack/metricbeat-windows-2016-windows-2016 - mage build unitTest
  • Took 0 min 7 sec . View more details here
  • Description: mage build unitTest
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 1'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor Author

mergify bot commented Dec 12, 2022

This pull request has not been merged yet. Could you please review and merge it @gpop63? 🙏

1 similar comment
@mergify
Copy link
Contributor Author

mergify bot commented Dec 19, 2022

This pull request has not been merged yet. Could you please review and merge it @gpop63? 🙏

@endorama
Copy link
Member

Closing as no more 8.4 releases are planned

@endorama endorama closed this Dec 19, 2022
@mergify mergify bot deleted the mergify/bp/8.4/pr-33655 branch December 19, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gpop63 gpop63

Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elasticmachine @endorama @gpop63