Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS Cloudwatch] Changed module to call ListMetrics API only once per region #34055

Merged
merged 14 commits into from
Dec 19, 2022
Merged

[AWS Cloudwatch] Changed module to call ListMetrics API only once per region #34055

merged 14 commits into from
Dec 19, 2022

Conversation

girodav
Copy link
Contributor

@girodav girodav commented Dec 15, 2022 •
edited
Loading

What does this PR do?

This PR modifies the AWS Cloudwatch module to call ListMetrics API only once per region, instead of once per namespace. Any namespaces that are part of ListMetrics API's response, but not configured to be queried, are removed in code.

Why is it important?

ListMetrics API is billed per number of calls, so reducing the total number of calls lead to cost savings for users of the AWS Cloudwatch module.

References:

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@girodav girodav added enhancement aws Enable builds in the CI for aws cloud testing labels Dec 15, 2022
@girodav girodav self-assigned this Dec 15, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 15, 2022
@botelastic
Copy link

botelastic bot commented Dec 15, 2022

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @girodav? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 15, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-16T15:02:06.559+0000

  • Duration: 91 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 4261
Skipped 1042
Total 5303

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@girodav girodav marked this pull request as ready for review December 15, 2022 10:40
@girodav girodav requested a review from a team as a code owner December 15, 2022 10:40
@girodav
Copy link
Contributor Author

girodav commented Dec 15, 2022

/test

@aspacca aspacca self-requested a review December 15, 2022 10:46
aspacca
aspacca reviewed Dec 15, 2022
View reviewed changes
Copy link

@aspacca aspacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see my comment

@girodav girodav assigned kaiyan-sheng and unassigned kaiyan-sheng Dec 15, 2022
@girodav girodav requested a review from kaiyan-sheng December 15, 2022 12:50
@girodav girodav force-pushed the listmetrics-by-region branch from e05b35c to 7055a16 Compare December 16, 2022 13:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@girodav girodav merged commit 5fd0041 into elastic:main Dec 19, 2022
@girodav girodav deleted the listmetrics-by-region branch December 19, 2022 10:00
@kwinstonix kwinstonix mentioned this pull request Apr 5, 2023
Closed
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@girodav @chrisberkhout
[AWS Cloudwatch] Changed module to call ListMetrics API only once per…
4ca146d 
… region (#34055)

* Changed cloudwatch module to call ListMetrics API only once per region, instead of per AWS namespace
* Refactored filterListMetricsOutput method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspacca aspacca aspacca approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@girodav girodav

Labels
aws Enable builds in the CI for aws cloud testing enhancement needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AWS Cloudwatch] Avoid calling ListMetrics by namespace
4 participants
@girodav @elasticmachine @aspacca @kaiyan-sheng