Export libbeat.outputs.acked_events via expvar #3411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monicasarbu
added
in progress
monicasarbu
force-pushed
the
export_redis_published_and_acked_events
branch
from
cae8fa2 to
37ef896
Compare
ruflin
reviewed
Jan 19, 2017
| @@ -17,6 +18,9 @@ import ( | |||
|
|
|||
| var ( | |||
| versionRegex = regexp.MustCompile(`redis_version:(\d+).(\d+)`) | |||
|
|
|||
| ackedEvents = expvar.NewInt("libbeat.redis.published_and_acked_events") | |||
There was a problem hiding this comment.
I suggest to name it
libbeat.redis.published.events.acked
libbeat.redis. published.events.not_acked
This corresponds better with our metricbeat conventions.
There was a problem hiding this comment.
I used this name to be similar with libbeat.elasticsearch.published_and_acked_events, libbeat.logstash.published_and_acked_events and libbeat.kafka.published_and_acked_events. I agree that the name is not ideal, so maybe we can change all of them in a separate PR.
There was a problem hiding this comment.
Yes, I kind of assumed you copied it from there. +1 on changing / reviewing all our naming for the metrics. We started this before we had our naming conventions, so most don't fit too well ...
Export libbeat.output.acked_events via expvar
monicasarbu
force-pushed
the
export_redis_published_and_acked_events
branch
from
915c6fe to
262aa94
Compare
monicasarbu
changed the title
10 tasks
monicasarbu
changed the title
|
Closing in favor of #3423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3422
With this PR, each Beat exports
libbeat.redis.published_and_acked_eventsandlibbeat.redis.published_but_not_acked_eventsvia expvar for Redis.In addition,
libbeat.outputs.acked_eventsis exported in order to send one metric for all outputs instead of one metric per output. In the case two outputs are enabled, the number of published events will be double.For example in case Redis and Elasticsearch outputs are enabled, then
libbeat.redis.published_and_acked_events: 48,libbeat.elasticsearch.published_and_acked_events: 48andlibbeat.outputs.acked_events: 96.