-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for optional metricsets in xpack mode #34273
Conversation
@klacabane friendly bump here if you have some time to review |
Thanks for separating out this change. I'm good with moving forward with it. I think eventually we should extend it this logic to make it possible to also disable metricsets that are on by default but we can do this in a follow up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This adds support for specifying that a metricset can also be enabled when
xpack.enabled: true
is set, but is not turned on by default. This allows for finer-grained control of when a metricset is enabled when using xpack mode. For example this will allow support for a configuration like:This only affects the
beat
,elasticsearch
,kibana
, andlogstash
modules for Stack Monitoring.Why is it important?
We are adding a new ingest metricset as "beta" in #34012. We want to be able to enable/disable this on Cloud deployments as we do testing. Since Cloud uses
xpack.enabled: true
we need a new way to have control over which metricsets are enabled.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Not possible yet since there's no metricsets using this
Related issues