-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heartbeat] Limit jobs by type via Env Vars #34307
Conversation
Fixes elastic#34290 by allowing users to control job limits via environment vars like `SYNTHETICS_LIMIT_{TYPE}`, so, to limit the max number of browser jobs one would use: `SYNTHETICS_LIMIT_BROWSER=90 ./heartbeat` This is primarily here to allow users to change the default browser limit in the elastic agent, which is impossible to change otherwise, since there's no way to set a good global config via Fleet.
Pinging @elastic/uptime (Team:Uptime) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Emilio Alvarez Piñeiro <[email protected]>
…to limit-jobs-via-env-var
This reverts commit e704940.
Fixes #34290 by allowing users to control job limits via environment vars like
SYNTHETICS_LIMIT_{TYPE}
, so, to limit the max number of browser jobs one would use:SYNTHETICS_LIMIT_BROWSER=90 ./heartbeat
This is primarily here to allow users to change the default browser limit in the elastic agent, which is impossible to change otherwise, since there's no way to set a good global config via Fleet.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
mage build && env SYNTHETICS_LIMIT_BROWSER=4 SYNTHETICS_LIMIT_HTTP=200 ./heartbeat -e -E cloud.id=$CLOUD_ID -E cloud.auth=$CLOUD_AUTH
Should yield the following logs: