-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log errors from v2 client errors channel #34392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
added
Team:Elastic-Agent
Label for the Agent team
backport-v8.6.0
Automated backport with mergify
labels
Jan 25, 2023
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jan 25, 2023
blakerouse
requested review from
fearful-symmetry and
faec
and removed request for
a team
January 25, 2023 15:49
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
Collaborator
cmacknz
approved these changes
Jan 26, 2023
cmacknz
reviewed
Jan 26, 2023
This pull request is now in conflicts. Could you fix it? 🙏
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
* Log errors from v2 client errors channel. * Add changelog entry. * Update changelog. (cherry picked from commit 4c46e5d)
blakerouse
added a commit
that referenced
this pull request
Jan 26, 2023
* Log errors from v2 client errors channel. * Add changelog entry. * Update changelog. (cherry picked from commit 4c46e5d) Co-authored-by: Blake Rouse <[email protected]>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Log errors from v2 client errors channel. * Add changelog entry. * Update changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds go-routine that reads errors from the
Errors()
channel and logs them.Why is it important?
Without this its possible that the elastic-agent-client will block if errors are not pulled off the
Errors()
channel. Errors communicating with the Elastic Agent are also not reported.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues