Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/module/okta: fill okta.request.ip_chain.* as a flattened object #34621

Merged
merged 1 commit into from
Feb 22, 2023
Merged

x-pack/filebeat/module/okta: fill okta.request.ip_chain.* as a flattened object #34621

merged 1 commit into from
Feb 22, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 21, 2023

What does this PR do?

Added to reflect addition in okta integration: elastic/integrations#3326

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.8-candidate labels Feb 21, 2023
@efd6 efd6 self-assigned this Feb 21, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 21, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 21, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-21T01:03:03.027+0000

  • Duration: 73 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 7555
Skipped 746
Total 8301

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review February 21, 2023 02:21
@efd6 efd6 requested a review from a team as a code owner February 21, 2023 02:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

kcreddy
kcreddy approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 1f1868d into elastic:main Feb 22, 2023
@efd6 efd6 added backport-v8.7.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Feb 23, 2023
mergify bot pushed a commit that referenced this pull request Feb 23, 2023
@efd6 @mergify
x-pack/filebeat/module/okta: fill okta.request.ip_chain.* as a flatte…
82637c5 
…ned object (#34621)

Added to reflect addition in okta integration: elastic/integrations#3326

(cherry picked from commit 1f1868d)

# Conflicts:
#	x-pack/filebeat/module/okta/fields.go
#	x-pack/filebeat/module/okta/system/test/okta-system-test.json.log-expected.json
@mergify mergify bot mentioned this pull request Feb 23, 2023
Merged
efd6 added a commit that referenced this pull request Feb 23, 2023
@mergify @efd6
[8.7](backport #34621) x-pack/filebeat/module/okta: fill okta.request…
2bc3489 
….ip_chain.* as a flattened object (#34657)

* x-pack/filebeat/module/okta: fill okta.request.ip_chain.* as a flattened object (#34621)

Added to reflect addition in okta integration: elastic/integrations#3326

(cherry picked from commit 1f1868d)

# Conflicts:
#	x-pack/filebeat/module/okta/fields.go
#	x-pack/filebeat/module/okta/system/test/okta-system-test.json.log-expected.json

* resolve conflicts

---------

Co-authored-by: Dan Kortschak <[email protected]>
Co-authored-by: Dan Kortschak <[email protected]>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
x-pack/filebeat/module/okta: fill okta.request.ip_chain.* as a flatte…
84bde6c 
…ned object (#34621)

Added to reflect addition in okta integration: elastic/integrations#3326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
8.8-candidate backport-v8.7.0 Automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @kcreddy