Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/cel: update mito extension version #34689

Merged
merged 2 commits into from
Mar 8, 2023
Merged

x-pack/filebeat/input/cel: update mito extension version #34689

merged 2 commits into from
Mar 8, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 27, 2023 •
edited
Loading

What does this PR do?

Adds:

  • Basic Authentication support at lib and request level
  • string manipulation reflecting functions from stdlib strings package

Why is it important?

Basic Authentication is advertised as a feature that the input support and requests have been made for support of string manipulation.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 self-assigned this Feb 27, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 27, 2023
@efd6 efd6 mentioned this pull request Feb 27, 2023
Merged
@efd6
Copy link
Contributor Author

efd6 commented Feb 28, 2023

/test

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 28, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-07T23:02:39.642+0000

  • Duration: 117 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 25987
Skipped 1962
Total 27949

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6
Copy link
Contributor Author

efd6 commented Feb 28, 2023

/test

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 34609-34610-cel upstream/34609-34610-cel
git merge upstream/main
git push upstream 34609-34610-cel

@efd6 efd6 force-pushed the 34609-34610-cel branch 4 times, most recently from ccf6066 to 63438ac Compare March 2, 2023 01:30
@efd6 efd6 marked this pull request as ready for review March 2, 2023 01:35
@efd6 efd6 requested review from a team as code owners March 2, 2023 01:35
@efd6 efd6 requested review from rdner and cmacknz and removed request for a team March 2, 2023 01:35
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor Author

efd6 commented Mar 2, 2023

/test

rdner
rdner approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the linter, it's a false positive, we've seen this before.

@efd6
Copy link
Contributor Author

efd6 commented Mar 2, 2023 •
edited
Loading

Yes, it's essentially golangci/golangci-lint-action#624.

@efd6
Copy link
Contributor Author

efd6 commented Mar 2, 2023

Will wait on @elastic/security-external-integrations for code changes in config.go and input.go.

@efd6
Copy link
Contributor Author

efd6 commented Mar 2, 2023

Missed the Strings import. Adding.

@efd6
Copy link
Contributor Author

efd6 commented Mar 3, 2023

/test

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 34609-34610-cel upstream/34609-34610-cel
git merge upstream/main
git push upstream 34609-34610-cel

@efd6 efd6 force-pushed the 34609-34610-cel branch 2 times, most recently from 7cdf183 to 7ad98c4 Compare March 3, 2023 07:56
@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 34609-34610-cel upstream/34609-34610-cel
git merge upstream/main
git push upstream 34609-34610-cel

efd6 added 2 commits March 8, 2023 09:31
@efd6
x-pack/filebeat/input/cel: update mito extension version
70f14b9 
Adds:

* Basic Authentication support at lib and request level
* string manipulation reflecting functions from stdlib strings package
@efd6
add missing import
d23d628
@efd6 efd6 force-pushed the 34609-34610-cel branch from 7ad98c4 to d23d628 Compare March 7, 2023 23:02
@efd6 efd6 merged commit e00506e into elastic:main Mar 8, 2023
mergify bot pushed a commit that referenced this pull request Mar 8, 2023
@efd6 @mergify
x-pack/filebeat/input/cel: update mito extension version (#34689)
ae49f42 
Adds:

* Basic Authentication support at lib and request level
* string manipulation reflecting functions from stdlib strings package

(cherry picked from commit e00506e)
@mergify mergify bot mentioned this pull request Mar 8, 2023
Merged
efd6 added a commit that referenced this pull request Mar 8, 2023
@mergify @efd6
[8.7](backport #34689) x-pack/filebeat/input/cel: update mito extensi…
c0e86ba 
…on version (#34767)

* x-pack/filebeat/input/cel: update mito extension version (#34689)

Adds:

* Basic Authentication support at lib and request level
* string manipulation reflecting functions from stdlib strings package

(cherry picked from commit e00506e)

* remove irrelevant changelog lines

---------

Co-authored-by: Dan Kortschak <[email protected]>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
x-pack/filebeat/input/cel: update mito extension version (#34689)
ac44026 
Adds:

* Basic Authentication support at lib and request level
* string manipulation reflecting functions from stdlib strings package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@rdner rdner rdner approved these changes

@cmacknz cmacknz Awaiting requested review from cmacknz cmacknz was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels
8.8-candidate backport-v8.7.0 Automated backport with mergify bug enhancement Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filebeat CEL input - string library functions not recognized Filebeat CEL input - basic auth does not work
4 participants
@efd6 @elasticmachine @rdner @andrewkroh