libbeat/monitoring/inputmon - Ignore dataset metrics without name and id

[andrewkroh]

What does this PR do?

This filters metrics from the /inputs/ endpoint for entities that lack an input name and id.

This is needed because we continued to use the "dataset" namespace in the monitoring registry instead of using a new one like "inputs". Originally I planned to use to new namespace but I stayed with dataset because I wanted to prevent a breaking change for existing users of the /dataset API endpoint. This meant that metrics from the log input (and possibly others) that don't yet follow the conventions need to be filtered.

Why is it important?

The data being produced from the /inputs/ API is different than what we expected.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

• Relates [Filebeat] Add /inputs/ route for Filebeat input metrics #33859

Logs

Prior to this change when using the log input you would get data like this from the /inputs/ API. This data lacks an id or an input name. Plus it creates an entry for every file rather than one entry for the log input itself (which could lead to a lot more data than we expected).

% curl http://localhost:6060/inputs/ | jq .
[
  {
    "last_event_published_time": "2023-03-21T17:07:30.704Z",
    "last_event_timestamp": "2023-03-21T17:07:30.704Z",
    "name": "/var/log/jamf.log",
    "read_offset": 173391,
    "size": 536730,
    "start_time": "2023-03-21T21:07:30.136Z"
  },
  {
    "last_event_published_time": "2023-03-21T17:07:30.704Z",
    "last_event_timestamp": "2023-03-21T17:07:30.704Z",
    "name": "/var/log/install.log",
    "read_offset": 275589,
    "size": 25889274,
    "start_time": "2023-03-21T21:07:30.142Z"
  }
]

[elasticmachine]

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-03-22T13:23:15.302+0000

• Duration: 68 min 16 sec

Test stats 🧪

Test	Results
Failed	0
Passed	26044
Skipped	1965
Total	28009

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)