x-pack/filebeat : Sanitize trace log filename to support multiple OS

[bhapas]

What does this PR do?

This PR sanitizes the request.tracer.filename in filebeat config to replace : and / characters with _ character.

Why is it important?

There is a problem with different path separators between HFS+ (colon, ':') and UFS (slash, '/'). This also means that HFS+ file names may contain the slash character and not colons, while the opposite is true for UFS file names. Reference

So the file structure seems to be corrupted in MacOS if the filename has : and the same happens in Unix based systems if the filename has /. Hence replacing them with _.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @bhapas? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-04-20T12:10:05.117+0000

• Duration: 74 min 8 sec

Test stats 🧪

Test	Results
Failed	0
Passed	2883
Skipped	175
Total	3058

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[elasticmachine]

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

[efd6]

nits

[andrewkroh]

Given that pretty much every operating system imposes some limits on file name length, I think it would be a good idea to impose some sort guard against really long IDs.

The id can be set to any value by a user and for stateful inputs Filebeat appends the URL. So this ID value could get really long. Perhaps we impose and document some arbitrary limit like * will include the first 64 characters of the input id.

[bhapas]

Given that pretty much every operating system imposes some limits on file name length, I think it would be a good idea to impose some sort guard against really long IDs.

The id can be set to any value by a user and for stateful inputs Filebeat appends the URL. So this ID value could get really long. Perhaps we impose and document some arbitrary limit like * will include the first 64 characters of the input id.

I had some discussion with Dan about this. May be we can take this in a separate issue to see what would be a nicer way to do this

[andrewkroh]

May be we can take this in a separate issue

Sure. #35157