x-pack/filebeat/input/cel: add execution budget and relax CSV mime name #35409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Filebeat
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This comment was marked as outdated.
This comment was marked as outdated.
This adds two features to improve user experience. The first is a guard rail to prevent users unwittingly constructing a CEL program that enters an infinite loop and blocking further processing. While CEL is not Turing complete, there is a Turing escape hatch in the form of the want_more field. If a user sets want_more to true and returns an event the inner execution loop will be re-run. If an error in the CEL program results in non-progress, this would result in an infinite loop. By providing a bound on the number of executions each periodic invocation can run, and warning when the budget is exceeded, this is mitigated. The second is a change to the look-up table for MIME types. While the documentation says that CSV MIME types are accessed via the name "text/csv; header=absent" and "text/csv; header=present" (with a space), it is probable that at some point someone will type this without a space and get a failure to parse. So add the no-space variants to the table.
andrewkroh
approved these changes
May 10, 2023
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
…me (#35409) This adds two features to improve user experience. The first is a guard rail to prevent users unwittingly constructing a CEL program that enters an infinite loop and blocking further processing. While CEL is not Turing complete, there is a Turing escape hatch in the form of the want_more field. If a user sets want_more to true and returns an event the inner execution loop will be re-run. If an error in the CEL program results in non-progress, this would result in an infinite loop. By providing a bound on the number of executions each periodic invocation can run, and warning when the budget is exceeded, this is mitigated. The second is a change to the look-up table for MIME types. While the documentation says that CSV MIME types are accessed via the name "text/csv; header=absent" and "text/csv; header=present" (with a space), it is probable that at some point someone will type this without a space and get a failure to parse. So add the no-space variants to the table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds two features to improve user experience. The first is a guard rail to prevent users unwittingly constructing a CEL program that enters an infinite loop and blocking further processing. While CEL is not Turing complete, there is a Turing escape hatch in the form of the want_more field. If a user sets want_more to true and returns an event the inner execution loop will be re-run. If an error in the CEL program results in non-progress, this would result in an infinite loop. By providing a bound on the number of executions each periodic invocation can run, and warning when the budget is exceeded, this is mitigated.
The second is a change to the look-up table for MIME types. While the documentation says that CSV MIME types are accessed via the name "text/csv; header=absent" and "text/csv; header=present" (with a space), it is probable that at some point someone will type this without a space and get a failure to parse. So add the no-space variants to the table.
Why is it important?
Improved user experience and reduced support load.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs