Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat][httpjson] Add delegated account support when using ADC #35507

Merged
merged 2 commits into from
May 22, 2023

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented May 18, 2023

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 18, 2023
@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @marc-gr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 18, 2023
@marc-gr marc-gr changed the title Add delegated account support when using ADC [filebeat][httpjson] Add delegated account support when using ADC May 18, 2023
@marc-gr marc-gr force-pushed the feat/httpjson-adc-delegated-account branch from caecfe7 to 318a7b0 Compare May 18, 2023 08:22
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-19T07:05:56.819+0000

  • Duration: 72 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 2908
Skipped 175
Total 3083

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@marc-gr marc-gr marked this pull request as ready for review May 18, 2023 08:32
@marc-gr marc-gr requested a review from a team as a code owner May 18, 2023 08:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/httpjson-adc-delegated-account upstream/feat/httpjson-adc-delegated-account
git merge upstream/main
git push upstream feat/httpjson-adc-delegated-account

@marc-gr marc-gr merged commit 9aed0b4 into elastic:main May 22, 2023
@marc-gr marc-gr deleted the feat/httpjson-adc-delegated-account branch May 22, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants