Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filebeat/input/internal/journald/pkg/journaldfield: add support for capability rendering #36470

Merged
merged 2 commits into from
Sep 5, 2023
Merged

filebeat/input/internal/journald/pkg/journaldfield: add support for capability rendering #36470

merged 2 commits into from
Sep 5, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Aug 30, 2023

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.11-candidate labels Aug 30, 2023
@efd6 efd6 requested a review from andrewkroh August 30, 2023 22:43
@efd6 efd6 self-assigned this Aug 30, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 30, 2023
@efd6 efd6 force-pushed the 36454-journald branch 2 times, most recently from b4c15af to a38354f Compare August 30, 2023 22:46
@andrewkroh
Copy link
Member

ECS advises capability names in uppercase.

https://github.com/elastic/ecs/blob/73788871c4fabc2ffcaa701ffbe625bc7ecc2126/generated/ecs/ecs_flat.yml#L11228

https://github.com/elastic/ecs/blob/73788871c4fabc2ffcaa701ffbe625bc7ecc2126/generated/ecs/ecs_flat.yml#L11236

@efd6
Copy link
Contributor Author

efd6 commented Aug 30, 2023

That's awful. OK

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 30, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-05T08:07:15.723+0000

  • Duration: 72 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 8218
Skipped 755
Total 8973

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review August 31, 2023 01:03
@efd6 efd6 requested a review from a team as a code owner August 31, 2023 01:03
@efd6 efd6 requested review from belimawr and rdner August 31, 2023 01:03
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 changed the title filebeat/input/internal/journald/pkg/journaldfield: add support for capablility rendering filebeat/input/internal/journald/pkg/journaldfield: add support for capability rendering Aug 31, 2023
@mergify

This comment was marked as outdated.

Sign in to view
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Sep 5, 2023
@mergify

This comment was marked as outdated.

Sign in to view
@efd6 efd6 merged commit 963a9e1 into elastic:main Sep 5, 2023
@kgeller kgeller mentioned this pull request Oct 2, 2023
Merged
4 tasks
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@efd6 @Scholar-Li
filebeat/input/internal/journald/pkg/journaldfield: add support for c…
e1d7cb8 
…apability rendering (elastic#36470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr belimawr approved these changes

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@efd6 efd6

Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat] journald input - map linux capabilities to ECS
5 participants
@efd6 @andrewkroh @elasticmachine @belimawr @pierrehilbert