Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes] Update Kubernetes and KSM version for 1.28 compatibility #36997

Merged
merged 3 commits into from
Nov 2, 2023
Merged

[Kubernetes] Update Kubernetes and KSM version for 1.28 compatibility #36997

merged 3 commits into from
Nov 2, 2023

Conversation

constanca-m
Copy link
Contributor

What

Supported Kubernetes versions are the ones being maintained currently: 1.26-1.28

For the state_* metricsets: supported versions are 2.8.2, 2.9.2 and 2.10. Steps:

  1. Delete _meta/test/ksm.v2.7.0 and add file for new supported version 2.10.0.
  2. Update docs.plain to include this latest version.

For each state_* metricset:

  1. Delete the old expected file.
  2. Update the files variable under the test file.
  3. Run go test -data to update the expected files.

For controller manager, proxy and scheduler:

  1. Remove files for 1.25 version under test.
  2. Add new file for version 1.28 and update testdata/docs.plain document with same content.

Additionally:

  1. Update K8s version in Jenkisfile
  2. Update K8s versions in deploy/kubernetes/Jenkinsfile.yml
  3. Update docs: update metricbeat/module/kubernetes/docs.asciidoc with the new compatible versions and run mage build to update the metricbeatbeat/docs/modules/kubernetes.asciidoc

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  1. Clone this branch.
  2. Run the tests for each metricset.

Related issues

Relates to https://github.com/elastic/observability-dev/issues/2802.

@constanca-m constanca-m added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Oct 31, 2023
@constanca-m constanca-m self-assigned this Oct 31, 2023
@constanca-m constanca-m requested review from a team as code owners October 31, 2023 11:54
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 31, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @constanca-m? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 90 min 25 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@@ -0,0 +1,10 @@
apiVersion: v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this added by mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I removed it now

@gizas
Copy link
Contributor

gizas commented Nov 1, 2023

According to this can we run go test --tags integration,kubernetes --data and recreate all subfolder?

@constanca-m
Copy link
Contributor Author

According to this can we run go test --tags integration,kubernetes --data and recreate all subfolder?

I ran the tests for each separately, while I was updating the files

@constanca-m constanca-m merged commit 3acd591 into elastic:main Nov 2, 2023
8 checks passed
@constanca-m constanca-m deleted the k8s-add-support-1.28 branch November 2, 2023 08:02
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
…elastic#36997)

* Update K8s version.

* Update K8s version.

* Remove extra prometheus.yaml file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Automation Label for the Observability productivity team Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants