Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes Test] Fix lint error on ktest.go #37294

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

constanca-m
Copy link
Contributor

Proposed commit message

Please explain:

  • WHAT: Fix the lint error on pre allocating the variables files.
  • WHY: I forgot to address this comment on the related PR. This is the fix for that.

@constanca-m constanca-m added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Dec 5, 2023
@constanca-m constanca-m requested a review from a team as a code owner December 5, 2023 10:42
@constanca-m constanca-m self-assigned this Dec 5, 2023
@constanca-m constanca-m requested a review from gizas December 5, 2023 10:42
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 5, 2023
Copy link
Contributor

mergify bot commented Dec 5, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @constanca-m? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-05T10:43:11.917+0000

  • Duration: 69 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 5031
Skipped 1051
Total 6082

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@constanca-m constanca-m merged commit 26bbb77 into elastic:main Dec 5, 2023
7 checks passed
@constanca-m constanca-m deleted the ksm-fix-lint-error branch December 5, 2023 13:16
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants