Make system process metricset honor cpu_ticks config option #3776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `cpu_ticks` is true in the config file, the system process metricset will report the number of “ticks” (actually jiffies on linux) used in user space (`system.process.cpu.user`), system (`system.process.cpu.system`), and total (`system.process.cpu.total.ticks`). Fixes elastic#3590
ruflin
approved these changes
Mar 20, 2017
| }, | ||
| "start_time": unixTimeMsToTime(process.Cpu.StartTime), | ||
| } | ||
| proc.Put("cpu.user", process.Cpu.User) |
There was a problem hiding this comment.
nice, that also cleans up the code. It bugs me that we only use .ticks for the total but that would be a BC break.
There was a problem hiding this comment.
I felt the same way, but didn't want to break BC.
There was a problem hiding this comment.
Lets keep it in mind to "potentially" break for 6.0 ;-)
ruflin
added
the
needs_backport
|
@andrewkroh I added |
monicasarbu
pushed a commit
to monicasarbu/beats
that referenced
this pull request
Mar 29, 2017
…3776) When `cpu_ticks` is true in the config file, the system process metricset will report the number of “ticks” (actually jiffies on linux) used in user space (`system.process.cpu.user`), system (`system.process.cpu.system`), and total (`system.process.cpu.total.ticks`). Fixes elastic#3590 (cherry picked from commit 92fa6c4)
tsg
added
v5.4.0
and removed
needs_backport
tsg
pushed a commit
to tsg/beats
that referenced
this pull request
Apr 12, 2017
…3776) When `cpu_ticks` is true in the config file, the system process metricset will report the number of “ticks” (actually jiffies on linux) used in user space (`system.process.cpu.user`), system (`system.process.cpu.system`), and total (`system.process.cpu.total.ticks`). Fixes elastic#3590 (cherry picked from commit 92fa6c4)
ruflin
pushed a commit
that referenced
this pull request
Apr 12, 2017
…4005) When `cpu_ticks` is true in the config file, the system process metricset will report the number of “ticks” (actually jiffies on linux) used in user space (`system.process.cpu.user`), system (`system.process.cpu.system`), and total (`system.process.cpu.total.ticks`). Fixes #3590 (cherry picked from commit 92fa6c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
cpu_ticksis true in the config file, the system process metricset will report the number of "ticks" (actually jiffies on linux) used in user space (system.process.cpu.user), system (system.process.cpu.system), and total (system.process.cpu.total.ticks).Fixes #3590