Introduce error reporting in schema #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
reviewed
Mar 22, 2017
| logp.Err("%s", err) | ||
| errs := multierror.Errors{} | ||
| errs = append(errs, err) | ||
| return errs |
There was a problem hiding this comment.
Could these lines be written as return multierror.Errors{err}? Would be nicer if it works.
|
I like the idea. Generally I'd suggest making this be the |
tsg
reviewed
Mar 24, 2017
metricbeat/schema/error.go
Outdated
| type Error struct { | ||
| key string | ||
| message string | ||
| errorType int |
There was a problem hiding this comment.
Would it make sense to make ErrorType a type so that it's restricted to the consts above?
5 tasks
ruflin
force-pushed
the
schema-apply-returns-errors
branch
from
3fddd75 to
6dd996a
Compare
ruflin
changed the title
Currently in schema errors are only reported through logging which makes testing difficult. This PR introduces the collection of errors during applying the schema. Now Apply returns a list of errors. Currently these are ignored to keep the same implementation as before. Over time this should be adjusted to handle errors correctly. Logging in the schema should be remove and moved up to the Metricsets itself. This change should also simplify testing of different versions in unit tests, as `schema.Apply` will return errors. Currently this check is done in the system tests checking the log itself which is not very efficient. ApplyNoError was introduced as a temporary workaround for the processors implementation. This is part of elastic#3807
ruflin
force-pushed
the
schema-apply-returns-errors
branch
from
6dd996a to
1a53e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in schema errors are only reported through logging which makes testing difficult. This PR introduces the collection of errors during applying the schema.
Now Apply returns a list of errors. Currently these are ignored to keep the same implementation as before. Over time this should be adjusted to handle errors correctly. Logging in the schema should be remove and moved up to the Metricsets itself.
This change should also simplify testing of different versions in unit tests, as
schema.Applywill return errors. Currently this check is done in the system tests checking the log itself which is not very efficient.ApplyNoError was introduced as a temporary workaround for the processors implementation.
This is part of #3807