Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update go module version to v8 #37920

Closed
wants to merge 1 commit into from
Closed

Enhancement: Update go module version to v8 #37920

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 8, 2024

Proposed commit message

The go module require version that matches release version
beats used to updated version in this issue
#15853
But forget to update to v8

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

@ghost ghost self-requested a review as a code owner February 8, 2024 07:21
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 8, 2024
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
4d9d8f2

Please, read and sign the above mentioned agreement if you want to contribute to this project

Copy link
Contributor

mergify bot commented Feb 8, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @maxmeng-oss? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@mergify mergify bot assigned ghost Feb 8, 2024
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2024-02-08T07:21:21.302+0000

  • Duration: 5 min 38 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/beats.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/maxmeng-oss return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/maxmeng-oss : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/maxmeng-oss : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/orgs/members#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Feb 8, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 8, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@pierrehilbert
Copy link
Collaborator

pierrehilbert commented Feb 8, 2024

Hello,
Thanks for contributing.
Could you please sign our contributor agreement?

@ghost ghost closed this Feb 8, 2024
@ghost
Copy link
Author

ghost commented Feb 8, 2024

I had assign a personal CLA, switch to my personal account to re-submit

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants