-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't leak testing packages into main #37939
Conversation
stretchr/testify was unintentionally and unnecessarily being imported by a package that's part of the libbeat public API. Fix that by making the code only part of the test package.
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💚 Build Succeeded
cc @axw |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and fixing!
stretchr/testify is unintentionally and unnecessarily being imported by a package that's part of the libbeat public API. Fix that by making the code only part of the test package.
Fixes elastic/apm-server#12580