Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't leak testing packages into main #37939

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Don't leak testing packages into main #37939

merged 1 commit into from
Feb 11, 2024

Conversation

axw
Copy link
Member

@axw axw commented Feb 9, 2024

stretchr/testify is unintentionally and unnecessarily being imported by a package that's part of the libbeat public API. Fix that by making the code only part of the test package.

Fixes elastic/apm-server#12580

stretchr/testify was unintentionally and
unnecessarily being imported by a package
that's part of the libbeat public API.
Fix that by making the code only part of
the test package.
@axw axw requested a review from a team as a code owner February 9, 2024 07:20
@axw axw requested review from ycombinator and faec February 9, 2024 07:20
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 9, 2024
Copy link
Contributor

mergify bot commented Feb 9, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @axw? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@mergify mergify bot assigned axw Feb 9, 2024
@axw axw added cleanup backport-skip Skip notification from the automated backport with mergify labels Feb 9, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @axw

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Feb 9, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 9, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-02-09T07:21:06.943+0000

  • Duration: 142 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 28853
Skipped 2018
Total 30871

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing!

@axw axw merged commit 3345106 into elastic:main Feb 11, 2024
116 checks passed
@axw axw deleted the unleak-testing branch February 11, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify cleanup Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev/test dependencies included in the final binary
4 participants