-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] ETW input - add basic metrics #38017
Merged
andrewkroh
merged 5 commits into
elastic:main
from
andrewkroh:feature/fb/etw-input-metrics
Mar 6, 2024
Merged
[Filebeat] ETW input - add basic metrics #38017
andrewkroh
merged 5 commits into
elastic:main
from
andrewkroh:feature/fb/etw-input-metrics
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
8bc342a
to
095ebb0
Compare
Add input metrics to for ETW. Remove the very verbose debug message that was in the hot path for processing each event. I think more metrics taken from the ETW session itself should be added separately (e.g. events lost, buffers lost). This lays the ground works needed to expose those metrics. Closes elastic#38007
095ebb0
to
3721e57
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
💚 Build Succeeded
History
cc @andrewkroh |
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
chemamartinez
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marc-gr
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-skip
Skip notification from the automated backport with mergify
enhancement
Filebeat
Filebeat
Team:Security-Windows Platform
Windows Platform Team in Security Solution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add input metrics to for ETW.
Remove the very verbose debug message that was in the hot path for
processing each event.
I think more metrics taken from the ETW session itself should be added
separately (e.g. events lost, buffers lost). This lays the ground work needed
to expose those metrics.
Closes #38007
Author checklist
Example data