-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] AWS Health metricbeat module #38370
Conversation
…lastic#31628) This prevents "monitored" from being written into event.outcome which does not allow this value according to ECS.
successSet := eventDetails.SuccessfulSet | ||
for x := range successSet { | ||
for y := range healthDetailsTemp { | ||
if awssdk.ToString(successSet[x].Event.Arn) == healthDetailsTemp[y].EventArn { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have to do this now, but perhaps for a future refactor, i wonder if it's simpler to maintain a map of ARNs to metric events, instead of having these comparisons in multiple places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I have only one question. This metricset has a collection period of 24 hours: does it collect the same events again if Filebeat/Agent restarts the metricset beforehand?
could this be the reason for the ID generation code that encoded the date in the ID? |
In the latest code, ID is auto-generated. |
/test |
in the old code where the ID was being generated by hand, it included a date. could the sub-24hr duplication be the reason why? |
I think it is. I took reference of AWS billing to include the ID. For AWS billing, the bill amount for the specific day remains the same. Also, having duplicate values have a significant effect. Also, the timestamp is always In the case of AWS health, the status of affected entities might vary across a day. The |
@elastic/elastic-agent-data-plane team, Requesting code owner approval for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for data plane
Proposed commit message
AWS Health assists in effectively managing ongoing events by offering continuous insight into the performance of your resources and the availability of your AWS services and accounts. By leveraging AWS Health events, users obtain valuable insights into how service and resource modifications may impact their applications hosted on AWS.
The AWS Health integration with Elastic will retrieve the following information:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
elastic/integrations#8907
Use cases
Screenshots
Logs