Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set owner of syslog reader and processor #38945

Merged

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Apr 15, 2024

The syslog reader and processor are owned by the @elastic/sec-deployment-and-devices team, but were not set in CODEOWNERS until now.

- syslog reader and processor is owned by elastic/sec-deployment-and-devices
@taylor-swanson taylor-swanson added the Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution label Apr 15, 2024
@taylor-swanson taylor-swanson self-assigned this Apr 15, 2024
@taylor-swanson taylor-swanson requested a review from a team as a code owner April 15, 2024 14:12
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 15, 2024
Copy link
Contributor

mergify bot commented Apr 15, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @taylor-swanson? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 13 min 28 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! always a pleasure to approve PRs that give more ownership to our team 🥲

@taylor-swanson taylor-swanson enabled auto-merge (squash) April 15, 2024 20:32
@taylor-swanson
Copy link
Contributor Author

@elastic/ingest-eng-prod, could we get an approval for this PR?

@taylor-swanson
Copy link
Contributor Author

I still need an approval from ingest-eng-prod.

Could somebody from @elastic/ingest-eng-prod please give this a review/approval?

cc @norrietaylor

@taylor-swanson taylor-swanson merged commit 99b2de0 into elastic:main Apr 18, 2024
21 checks passed
@taylor-swanson taylor-swanson deleted the syslog-processor-codeowner branch April 18, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants