Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issues with Heartbeat pipeline #39045

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Fixed issues with Heartbeat pipeline #39045

merged 2 commits into from
Apr 18, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Apr 18, 2024 •
edited
Loading

Proposed commit message

In scope of https://github.com/elastic/ingest-dev/issues/3072 - fixed issues with heartbeat pipeline (removed BEATS_PROJECT_NAME env var usage and updated commands to unified style)
BK Builds: https://buildkite.com/elastic/heartbeat/builds?branch=oakrizan%3Aheartbeat-fixes

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@oakrizan oakrizan added Team:Elastic-Agent Label for the Agent team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify labels Apr 18, 2024
@oakrizan oakrizan requested a review from dliappis April 18, 2024 11:56
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 18, 2024
@oakrizan oakrizan added :Windows macOS Enable builds in the CI for darwin testing labels Apr 18, 2024
@oakrizan oakrizan marked this pull request as ready for review April 18, 2024 12:02
@oakrizan oakrizan requested a review from a team as a code owner April 18, 2024 12:02
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 18, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 13 min 38 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

dliappis
dliappis requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for fixing this up!

I left a few asks, that I believe are in-scope, to harmonize this PR with how we are doing things with the other projects.

.buildkite/heartbeat/heartbeat-pipeline.yml Show resolved Hide resolved
.buildkite/heartbeat/heartbeat-pipeline.yml Show resolved Hide resolved
.buildkite/heartbeat/heartbeat-pipeline.yml Show resolved Hide resolved
@oakrizan oakrizan force-pushed the heartbeat-fixes branch 3 times, most recently from d41b2ba to 523887d Compare April 18, 2024 12:48
dliappis
dliappis approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oakrizan oakrizan merged commit b4ff53c into elastic:main Apr 18, 2024
157 of 164 checks passed
mergify bot pushed a commit that referenced this pull request Apr 18, 2024
@oakrizan @mergify
Fixed issues with Heartbeat pipeline (#39045)
745a32c 
* fixed issues in heartbeat pipeline

* pr fixes

(cherry picked from commit b4ff53c)
mergify bot pushed a commit that referenced this pull request Apr 18, 2024
@oakrizan @mergify
Fixed issues with Heartbeat pipeline (#39045)
3f449e5 
* fixed issues in heartbeat pipeline

* pr fixes

(cherry picked from commit b4ff53c)
mergify bot pushed a commit that referenced this pull request Apr 18, 2024
@oakrizan @mergify
Fixed issues with Heartbeat pipeline (#39045)
5740e73 
* fixed issues in heartbeat pipeline

* pr fixes

(cherry picked from commit b4ff53c)

# Conflicts:
#	.buildkite/heartbeat/heartbeat-pipeline.yml
This was referenced Apr 18, 2024
Merged
Merged
Merged
oakrizan added a commit that referenced this pull request Apr 18, 2024
@oakrizan
Fixed issues with Heartbeat pipeline (#39045)
0ff5093 
* fixed issues in heartbeat pipeline

* pr fixes

(cherry picked from commit b4ff53c)
oakrizan added a commit that referenced this pull request Apr 18, 2024
@oakrizan
Fixed issues with Heartbeat pipeline (#39045)
f26b2c4 
* fixed issues in heartbeat pipeline

* pr fixes

(cherry picked from commit b4ff53c)
oakrizan added a commit that referenced this pull request Apr 19, 2024
@oakrizan
Fixed issues with Heartbeat pipeline (#39045)
8059564 
* fixed issues in heartbeat pipeline

* pr fixes

(cherry picked from commit b4ff53c)

# Conflicts:
#	.buildkite/heartbeat/heartbeat-pipeline.yml
oakrizan added a commit that referenced this pull request Apr 19, 2024
@oakrizan
Fixed issues with Heartbeat pipeline (#39045)
00b891d 
* fixed issues in heartbeat pipeline

* pr fixes

(cherry picked from commit b4ff53c)
oakrizan added a commit that referenced this pull request Apr 19, 2024
@mergify @oakrizan
Fixed issues with Heartbeat pipeline (#39045) (#39048)
9c76f8d 
* fixed issues in heartbeat pipeline

* pr fixes

(cherry picked from commit b4ff53c)

Co-authored-by: Olga Naydyonock <[email protected]>
oakrizan added a commit that referenced this pull request Apr 19, 2024
@mergify @oakrizan
[8.13](backport #39045) Fixed issues with Heartbeat pipeline (#39049)
fe95534 
* Fixed issues with Heartbeat pipeline (#39045)

* fixed issues in heartbeat pipeline

* pr fixes

(cherry picked from commit b4ff53c)

# Conflicts:
#	.buildkite/heartbeat/heartbeat-pipeline.yml

* resolved conflicts

---------

Co-authored-by: Olga Naydyonock <[email protected]>
Co-authored-by: Olga Naidjonoka <[email protected]>
oakrizan added a commit that referenced this pull request Apr 19, 2024
@mergify @oakrizan
Fixed issues with Heartbeat pipeline (#39045) (#39050)
ffd19c1 
* fixed issues in heartbeat pipeline

* pr fixes

(cherry picked from commit b4ff53c)

Co-authored-by: Olga Naydyonock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@oakrizan oakrizan

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify macOS Enable builds in the CI for darwin testing Team:Elastic-Agent Label for the Agent team :Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oakrizan @elasticmachine @dliappis