Update codecov config #3906
Merged
Update codecov config #3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, retest it |
tsg
approved these changes
Apr 5, 2017
codecov.yml
Outdated
| default: | ||
| target: auto | ||
| # Overall coverage should never drop more then 1% | ||
| threshold: 0.5 |
There was a problem hiding this comment.
Comment above is wrong, says 1% :)
There was a problem hiding this comment.
argh, updated the value and not the comment ...
| target: auto | ||
| threshold: 0.1 | ||
| # Allows PRs without tests, overall stats count | ||
| threshold: 100 |
There was a problem hiding this comment.
Does this mean this check will always be green, because threshlod is 100?
There was a problem hiding this comment.
Exactly. Patch level check will always be green. Otherwise if 1 code line is added which is not covered, it would have 0% coverage.
Codecov will report coverage for the patch and for the project based on the pull request. In case the overall coverage drops by more then 0.5% the pull request will fail. It is still possible to have pull requests without tests which will not fail because the overall coverage did not change too much.
ruflin
force-pushed
the
codecov-adjustments
branch
from
d1e802e to
3df95f2
Compare
|
Update version pushed. |
|
jenkins, retest it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codecov will report coverage for the patch and for the project based on the pull request. In case the overall coverage drops by more then 0.5% the pull request will fail. It is still possible to have pull requests without tests which will not fail because the overall coverage did not change too much.