-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agentbeat: remove unused files from package and silence new error message #39064
Conversation
Beats no longer reads config files at startup when run as part of agent.
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
|
/package |
@cmacknz should we fix the linter issues? |
The latest packaging run succeeded but didn't update the PR status here, https://beats-ci.elastic.co/job/Beats/job/packaging/job/PR-39064/6/. Merging. |
…sage (#39064) (#39159) * Remove Beat config files from agentbeat. Beats no longer reads config files at startup when run as part of agent. * Silence new error message with agentbeat. * Add comment to log line. (cherry picked from commit e6cae46) Co-authored-by: Craig MacKenzie <[email protected]>
Any plans to cut a v7 and v8 release with this change? |
Not as part of this change. Some time ago it was decided that we would avoid creating a v8 to avoid the toil of updating the import paths across 100s of repositories. |
Removes the individual beat configuration files and the README from the agentbeat package. Beats don't read their configuration files when running under agent since 8.6, and the README is wrong for agentbeat (but not the other beats it is templated for).
I also silenced a new error log I noticed that results because the modules sub-directory is no longer present.
The package contents after this change are:
The certs and lenses directories are osquery specific.
What is included in an 8.14.0 agent is (Notice the presence of the readme and beat config files):
Tested by extracting the new package into the components directory of a new agent and making sure the Beats start. I don't know that we have a better way to test agentbeat in this repository yet.