Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xpack/filebeat & xpack/metricbeat pipelines to match Jenkins steps #39211

Merged
merged 17 commits into from
May 17, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Apr 25, 2024

Proposed commit message

Updated x-pack/filebeat and x-pack/metricbeat pipelines to match same steps & commands as in Jenkins.

Jenkins vs. Buildkite comparison

BK builds:

For both pipelines updated cloud test environment setup script and test commands to match Jenkins.

x-pack/filebeat: Cloud (MODULE) Tests failure is not related to current PR changes.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • .buildkite/x-pack/pipeline.xpack.filebeat.yml
  • .buildkite/x-pack/pipeline.xpack.metricbeat.yml

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

BK builds:
x-pack/filebeat: https://buildkite.com/elastic/beats-xpack-filebeat/builds?branch=oakrizan%3Axpack-filebeat-fixes
x-pack/metricbeat: https://buildkite.com/elastic/beats-xpack-metricbeat/builds?branch=oakrizan%3Axpack-filebeat-fixes

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 25, 2024
Copy link
Contributor

mergify bot commented Apr 25, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @oakrizan? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@oakrizan oakrizan added :Windows macOS Enable builds in the CI for darwin testing arm Enable builds in the CI for ARM testing labels Apr 25, 2024
@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch from cf04d64 to f238077 Compare April 25, 2024 12:39
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 25, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-05-09T11:57:24.624+0000

  • Duration: 12 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch 2 times, most recently from e243fad to 80030ff Compare April 26, 2024 08:01
@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch 2 times, most recently from 1603b3a to 56bfd94 Compare April 26, 2024 15:08
@oakrizan oakrizan added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify Team:Ingest-EngProd backport-v8.14.0 Automated backport with mergify labels Apr 26, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 26, 2024
@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch from 56bfd94 to a41715e Compare April 26, 2024 16:32
@oakrizan oakrizan marked this pull request as ready for review April 26, 2024 16:37
@oakrizan oakrizan requested a review from a team as a code owner April 26, 2024 16:37
@oakrizan oakrizan requested review from dliappis and pazone April 26, 2024 16:38
@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch 2 times, most recently from 2f39742 to 360f65a Compare April 29, 2024 08:19
@oakrizan oakrizan added the aws Enable builds in the CI for aws cloud testing label Apr 29, 2024
@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch 3 times, most recently from 8a65cc2 to 0cc6b2c Compare April 30, 2024 14:31
Copy link
Contributor

mergify bot commented May 14, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b xpack-filebeat-fixes upstream/xpack-filebeat-fixes
git merge upstream/main
git push upstream xpack-filebeat-fixes

@oakrizan
Copy link
Contributor Author

oakrizan commented May 16, 2024

@dliappis PTAL 🙏

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left a small comment that can be addressed without another review cycle.

.buildkite/x-pack/pipeline.xpack.metricbeat.yml Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented May 16, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b xpack-filebeat-fixes upstream/xpack-filebeat-fixes
git merge upstream/main
git push upstream xpack-filebeat-fixes

@oakrizan oakrizan removed the aws Enable builds in the CI for aws cloud testing label May 17, 2024
@oakrizan oakrizan enabled auto-merge (squash) May 17, 2024 06:31
@oakrizan oakrizan merged commit bf13818 into elastic:main May 17, 2024
169 checks passed
mergify bot pushed a commit that referenced this pull request May 17, 2024
…teps (#39211)

Updated x-pack/filebeat and x-pack/metricbeat pipelines to match same steps & commands as in Jenkins

(cherry picked from commit bf13818)
mergify bot pushed a commit that referenced this pull request May 17, 2024
…teps (#39211)

Updated x-pack/filebeat and x-pack/metricbeat pipelines to match same steps & commands as in Jenkins

(cherry picked from commit bf13818)

# Conflicts:
#	.buildkite/x-pack/pipeline.xpack.filebeat.yml
#	.buildkite/x-pack/pipeline.xpack.metricbeat.yml
mergify bot pushed a commit that referenced this pull request May 17, 2024
…teps (#39211)

Updated x-pack/filebeat and x-pack/metricbeat pipelines to match same steps & commands as in Jenkins

(cherry picked from commit bf13818)

# Conflicts:
#	.buildkite/x-pack/pipeline.xpack.filebeat.yml
#	.buildkite/x-pack/pipeline.xpack.metricbeat.yml
oakrizan added a commit to oakrizan/beats that referenced this pull request May 17, 2024
…teps (elastic#39211)

Updated x-pack/filebeat and x-pack/metricbeat pipelines to match same steps & commands as in Jenkins
oakrizan added a commit to oakrizan/beats that referenced this pull request May 17, 2024
…teps (elastic#39211)

Updated x-pack/filebeat and x-pack/metricbeat pipelines to match same steps & commands as in Jenkins
oakrizan pushed a commit that referenced this pull request May 17, 2024
…teps (#39211) (#39610)

Updated x-pack/filebeat and x-pack/metricbeat pipelines to match same steps & commands as in Jenkins
oakrizan pushed a commit that referenced this pull request May 17, 2024
…lines to match Jenkins steps (#39609)

Updated x-pack/filebeat and x-pack/metricbeat pipelines to match same steps & commands as in Jenkins
oakrizan pushed a commit that referenced this pull request May 17, 2024
…lines to match Jenkins steps (#39608)

Updated x-pack/filebeat and x-pack/metricbeat pipelines to match same steps & commands as in Jenkins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Enable builds in the CI for ARM testing backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify macOS Enable builds in the CI for darwin testing Team:Ingest-EngProd :Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants