Manage Azure SDKs version with Dependabot #39495
Conversation
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
zmoog
added
the
Team:obs-ds-hosted-services
botelastic
bot
removed
the
needs_team
zmoog
changed the title
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
.github/dependabot.yml
Outdated
| groups: | ||
| azure-sdk-for-go: | ||
| patterns: | ||
| - "github.com/Azure/azure-sdk-for-go/*" | ||
| azure-event-hubs-go: | ||
| patterns: | ||
| - "github.com/Azure/azure-event-hubs-go/*" |
There was a problem hiding this comment.
Rather than introducing a new package-ecosystem: gomod block, would it make sense to just update the existing block above with the groups and adding to its allow list?
There was a problem hiding this comment.
Yeah, now I see that apm-server has two blocks because each one targets a different directory.
I'm updating the existing block!
There was a problem hiding this comment.
I just noticed that by adding a package-ecosystem: gomod, we could set a reviewers option to direct PRs to our team.
Do you think it's worth adding a second package-ecosystem: gomod to customize reviewers, or it's better to keep things as simple as possible and just add a group or allow for the Azure dependencies?
I mean something like:
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: "daily"
reviewers:
- "elastic/obs-ds-hosted-services"
groups:
azure-sdk-for-go:
patterns:
- "github.com/Azure/azure-sdk-for-go/*"
azure-event-hubs-go:
patterns:
- "github.com/Azure/azure-event-hubs-go/*"There was a problem hiding this comment.
That's a good point. I think it would be ideal if the hosted services team were flagged for review, so having a separate block sounds like the way to go after all.
There was a problem hiding this comment.
Let me try this: I created a block for CSPs, so we can add a group for each CSP and target specific teams.
# Cloud providers' SDK dependencies
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: "daily"
reviewers:
- "elastic/obs-ds-hosted-services"
groups:
azure-sdks:
patterns:
- "github.com/Azure/azure-sdk-for-go/*"
- "github.com/Azure/azure-event-hubs-go/*"
- "github.com/Azure/go-autorest/*"
- "github.com/Azure/azure-storage-blob-go/*"
|
Hey @elastic/ingest-eng-prod, whenever you have a moment, could you please take a look at this pull request? 🙇 |
- Drop the ignore for "github.com/elastic/beats/v7". - Consolidate the github.com/Azure/azure* dependencies as allows in the existing gomod block.
Created a block for CSPs, so we can group together there dependencies and target a specific teams as reviewers.
zmoog
force-pushed
the
zmoog/manage-azure-sdk-dependencies-with-dependabot
branch
from
ce67717 to
301a4ab
Compare
The elastic/obs-infraobs-integrations team is probably interested in staying up to date with the Azure SDK for Go updates.
| interval: "daily" | ||
| reviewers: | ||
| - "elastic/obs-ds-hosted-services" | ||
| - "elastic/obs-infraobs-integrations" |
There was a problem hiding this comment.
since this is an automation task that will open pull request(s) (right?), does it make sense that we also add the corresponding labels to the PR, as e.g. done above:
labels:
- automation
- dependabot
There was a problem hiding this comment.
since this is an automation task that will open pull request(s) (right?)
Yep.
Ouch, I missed the labels! Thank you for pointing this out. Added!
zmoog
changed the title
Proposed commit message
Set up Dependabot to manage the Azure SDK version.
With the current reactive and manual process, our dependencies are often outdated. To release a bugfix to a dependency, we need to wait for the following stack release instead of merging it shortly after it's available from Azure.
See #39492 to learn more.
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Tasks
allowlist #40150