Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libbeat: added module integration test step #39581

Merged
merged 3 commits into from
May 16, 2024
Merged

Libbeat: added module integration test step #39581

merged 3 commits into from
May 16, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented May 15, 2024 •
edited
Loading

Proposed commit message

Added missing integration module tests for next major Elastic stack to libbeat Buildkite pipeline for 7.17 to match Jenkins.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • .buildkite/libbeat/pipeline.libbeat.yml

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

BK builds: https://buildkite.com/elastic/beats-libbeat/builds?branch=oakrizan%3Aaligning-libbeat-with-7-17

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 15, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 15, 2024
@oakrizan oakrizan marked this pull request as ready for review May 15, 2024 13:42
@oakrizan oakrizan requested a review from a team as a code owner May 15, 2024 13:42
dliappis
dliappis requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the exception of two typos

.buildkite/libbeat/pipeline.libbeat.yml Outdated Show resolved Hide resolved
.buildkite/libbeat/pipeline.libbeat.yml Outdated Show resolved Hide resolved
@oakrizan oakrizan added the ci label May 15, 2024
@dliappis dliappis self-requested a review May 15, 2024 14:49
dliappis
dliappis approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oakrizan oakrizan merged commit 3122641 into elastic:7.17 May 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@alexsapran alexsapran Awaiting requested review from alexsapran

@pazone pazone Awaiting requested review from pazone

Assignees

@oakrizan oakrizan

Labels
ci Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oakrizan @dliappis