Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.14](backport #39535) [Heartbeat] Add stringer redaction to synthexec cmd #39592

Merged
merged 2 commits into from
May 16, 2024
Merged

[8.14](backport #39535) [Heartbeat] Add stringer redaction to synthexec cmd #39592

merged 2 commits into from
May 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 16, 2024 •
edited by zube bot
Loading

Proposed commit message

Redact synthetics cmd output to prevent logging of user-defined parameters.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

N/A

How to test this PR locally

  1. Build heartbeat locally.
  2. Add a browser monitor with any playwrightOpts or params.
  3. Run and check logs show playwrightOpts or params as REDACTED
This is an automatic backport of pull request #39535 done by [Mergify](https://mergify.com).

@emilioalvap @mergify
[Heartbeat] Add stringer redaction to synthexec cmd (#39535)
ce330a8 
Redact synthetics cmd output to prevent logging of user-defined parameters.

---------

Co-authored-by: Vignesh Shanmugam <[email protected]>
(cherry picked from commit 7306bd4)
@mergify mergify bot requested a review from a team as a code owner May 16, 2024 10:37
@mergify mergify bot added the backport label May 16, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 16, 2024
@vigneshshanmugam vigneshshanmugam added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label May 16, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 16, 2024
@vigneshshanmugam vigneshshanmugam enabled auto-merge (squash) May 16, 2024 17:44
@vigneshshanmugam vigneshshanmugam merged commit 9dacbdb into 8.14 May 16, 2024
14 of 15 checks passed
@vigneshshanmugam vigneshshanmugam deleted the mergify/bp/8.14/pr-39535 branch May 16, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@emilioalvap emilioalvap

Labels
backport Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elasticmachine @vigneshshanmugam @emilioalvap