-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate needed .ci/* scripts into .buildkite/* ( elastic#3353 ) #39661
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
A couple of suggestions:
-
Let's wait that https://github.com/elastic/beats/pull/39648/files get's merged because it changes the version of
localstack
in the docker-compose file -
Let's run the entire testing suite by adding all the optional GH labels
aws
,:Windows
,macOS
to ensure nothing breaks with this.
@ev1yehor fyi, after adding labels (thanks for doing that!) we need to manually retrigger tests by leaving a comment like #39392 (comment) -- trigger phrase can be found in beats/.buildkite/pull-requests.json Lines 12 to 13 in 809e001
|
/test |
This pull request is now in conflicts. Could you fix it? 🙏
|
/test |
1 similar comment
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no docker-compose.yml on 7.17. I believe that file shouldn't be backported there. WDYT @dliappis?
Indeed, thanks for catching. However, we still have references to the non-existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
seems that docker-compose got trigger as expected: https://buildkite.com/elastic/beats-xpack-filebeat/builds/3013#018fba0c-7e0b-43ad-b640-57c0f0689171/157-158
* Migrate files and change path to them * Delete files that was migrated to new path (cherry picked from commit f411b06) # Conflicts: # .buildkite/deploy/docker/docker-compose.yml
* Migrate files and change path to them * Delete files that was migrated to new path (cherry picked from commit f411b06)
* Migrate files and change path to them * Delete files that was migrated to new path (cherry picked from commit f411b06)
…) (#39750) * Migrate files and change path to them * Delete files that was migrated to new path (cherry picked from commit f411b06) Co-authored-by: ev1yehor <[email protected]>
…) (#39748) * Migrate files and change path to them * Delete files that was migrated to new path (cherry picked from commit f411b06) # Conflicts: # .buildkite/deploy/docker/docker-compose.yml Co-authored-by: ev1yehor <[email protected]>
Proposed commit message
Migrate needed .ci/* scripts into .buildkite/* and change path for them.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Logs