-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Fix handling of custom Endpoint when using S3 + SQS #39722
Conversation
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
We currently use AWS VPC interface endpoints for SQS and S3. For SQS we do have "Private DNS names" enabled, and so we do not need to set an endpoint for SQS (i.e. traffic to It's not obvious to me from the comments if this change will enable us to use the input in this way. Ideally we would just set (or omit) an endpoint per AWS service, which would allow us to use a "https://bucket.vpce-..." endpoint for S3 and not use an endpoint for SQS. |
this was not supposed to merge, it was just an example for how to include it post s3/sqs refactor, ill close the PR |
The endpoint handling is all or nothing, so I do not believe this change does not offer setting a specific endpoint for one component or the other. |
Fix issues described in #39706 that prevent using a custom endpoint with S3 + SQS.
Users can workaround this issue via S3 bucket polling. The S3 bucket polling still works just fine with a custom endpoint, it's just adding in SQS where it breaks. We need to publish a elastic/integrations#9865
Work required for Main:
https://s3.us-east-1.abc.xyz
so users don't have to specify a region