Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metricbeat to match common styling && Jenkins steps on 7.17 #39908

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Update metricbeat to match common styling && Jenkins steps on 7.17 #39908

merged 2 commits into from
Jun 17, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Jun 14, 2024 •
edited
Loading

Proposed commit message

Updated metricbeat pipeline to match common styling && steps from Jenkins on 7.17.
Removed unnecessary kind setup, since it's already pre-intalled on base Linux images (https://github.com/elastic/ingest-dev/issues/3238)
Updated kind & K8S versions as was on Jenkins 7.17 to fix Go Int test failure

Jenkins vs. Buildkite: https://gist.github.com/oakrizan/e3eaa28cb7848710ff1f1cb7f4a189a7

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • .buildkite/metricbeat/pipeline.yml

Related issues

Logs

BK builds: https://buildkite.com/elastic/beats-metricbeat/builds?branch=oakrizan%3Ametricbeat-postmigration-fixes-7-17

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 14, 2024
@oakrizan oakrizan changed the title Update metricbeat to match common styling && Jenkins steps Update metricbeat to match common styling && Jenkins steps on 7.17 Jun 14, 2024
@oakrizan oakrizan force-pushed the metricbeat-postmigration-fixes-7-17 branch from 506931a to e07ffc1 Compare June 14, 2024 20:26
@oakrizan oakrizan added :Windows ci macOS Enable builds in the CI for darwin testing arm Enable builds in the CI for ARM testing Team:Ingest-EngProd labels Jun 14, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 14, 2024
@oakrizan oakrizan force-pushed the metricbeat-postmigration-fixes-7-17 branch from 0805e23 to f7bd2c9 Compare June 15, 2024 07:51
@oakrizan oakrizan mentioned this pull request Jun 15, 2024
Merged
9 tasks
@oakrizan oakrizan marked this pull request as ready for review June 15, 2024 08:33
@oakrizan oakrizan requested a review from a team as a code owner June 15, 2024 08:33
@oakrizan oakrizan enabled auto-merge (squash) June 17, 2024 09:43
dliappis
dliappis approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; left a typo suggestion that doesn't require another review

.buildkite/metricbeat/pipeline.yml Show resolved Hide resolved
@oakrizan oakrizan merged commit ae75ea6 into elastic:7.17 Jun 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@alexsapran alexsapran Awaiting requested review from alexsapran

@pazone pazone Awaiting requested review from pazone

Assignees

@oakrizan oakrizan

Labels
arm Enable builds in the CI for ARM testing ci macOS Enable builds in the CI for darwin testing Team:Ingest-EngProd :Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oakrizan @dliappis