[8.14](backport #40081) [debugPrintProcessor]: exit directly when log doesn't have debug level enabled

[mergify]

Proposed commit message

This PR is the aftermath of profiling the netflow integration test of this PR (PS: the pcap I used as input is ~25MB thus I won't include it in beats repo)

So this is the cpu profile flamegraph before the commit of this PR

As we can see debugPrintProcessor is invoked and we pay the "performance" price of encoding every event in json even when our log isn't set up with DEBUG level.

The respective cpu profile flamegraph after this PR with debugPrintProcessor still being there but exiting directly when log DEBUG is not enabled

Extracting the average EPS of the aformentioned netflow integration tested on my local macbook with a local ES inside a container

Before this PR	With this PR
18490	33760

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

N/A

Author's Checklist

N/A

How to test this PR locally

Help get this PR merged or clone it and apply this small commit there 🙂

cd x-pack/filebeat
mage docker:composeUp

run go profiler against TestNetFlowIntegration

Related issues

• Relates [Filebeat] Auto-scale number of netflow decoder workers  #37761

Use cases

N/A

Screenshots

Look at description

Logs

N/A

---

This is an automatic backport of pull request #40081 done by Mergify.

[mergify]

Cherry-pick of 58f4fc8 has failed:

On branch mergify/bp/8.14/pr-40081
Your branch is up to date with 'origin/8.14'.

You are currently cherry-picking commit 58f4fc8579.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   libbeat/publisher/processing/processors.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[botelastic]

This pull request doesn't have a Team:<team> label.

[mergify]

This pull request has not been merged yet. Could you please review and merge it @pkoutsovasilis? 🙏

[pierrehilbert]

@pkoutsovasilis we will have our first 8.14.3 today, could you please take care of this one asap?

[pkoutsovasilis]

hi @pierrehilbert, as far as I can tell this PR isn't required for 8.14.x as the change that introduced the debugPrintProcessor isn't here, so we are all good. In other words let's close this PR

PS: I don't remember adding the backport 8.14 on the original PR 😀

[pierrehilbert]

@cmacknz added it, from what I can understand in this comment #40081 (comment), we need it for standalone Beats prior to 8.15

[pkoutsovasilis]

@cmacknz added it, from what I can understand in this comment #40081 (comment), we need it for standalone Beats prior to 8.15

interesting... The commit that introduced it is this de3318d and I see it only in branches main and 8.15 so I think the backporting to 8.14 was an accident!?

git branch -a --contains de3318d19e66dbcecf0ef5235a61e22035d24a36
remotes/beats/8.15
remotes/beats/main
...

[pierrehilbert]

I think Craig was talking about 83dfb2f

[pkoutsovasilis]

good morning @pierrehilbert, I still think that this PR is not required. Maybe @cmacknz you can help us here? 🙂

[mergify]

This pull request has not been merged yet. Could you please review and merge it @pkoutsovasilis? 🙏

[mergify]

This pull request has not been merged yet. Could you please review and merge it @pkoutsovasilis? 🙏