-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global processor reload #40312
base: main
Are you sure you want to change the base?
Global processor reload #40312
Conversation
Delay instantiation of Pipeline object till the first client (input) tries to connect to it. The idea is to use a builder object for the Pipeline on which we can set parameters (in this case the global processor config) until the Pipeline is instantiated. Once the Pipeline is instantiated, the global processor reloader will return a specific error, signaling that to reload configuration we need a new Pipeline (i.e. a beat restart). At this point in the code the reload and restart seem to work, however it seems that the output unit is not set correctly (we probably need some additional hook to correctly wire the Pipeline and the Output object
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
This pull request is now in conflicts. Could you fix it? 🙏
|
Proposed commit message
Alternative approach derived from PR #40091 .
To reload the global processor we delay instantiating the Pipeline object similarly to what's done with output: we allow to load using settings from the control protocol exactly once; if more changes come in a restart of the beat is required.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs