-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filebeat][decode_cef] Add hyphen support #40427
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
… the latest regel version
…g 'Unreachable code' from generated go files.
2611086
to
f0ca09b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This pull request is now in conflicts. Could you fix it? 🙏
|
Hey @andrewkroh - are we waiting for code owners' review? |
Yeah, I was giving the little time in case anyone from @elastic/sec-deployment-and-devices wanted to comment. I'll merge it after CI finishes today. |
run docs-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution @vinit-chauhan! LGTM
run docs-build |
/test |
This adds support for hyphens (`-`) in extension keys. The CEF spec says that extension keys alphanumeric. So this is a deviation, but a minor one that is inline with past deviations to allow dots in extension keys. I have also added .ri file to gitignore file as they are intermediate files generated by regel. Closes elastic#40348
Proposed commit message
This PR Adds support for
-
in the extension keys.To do this, I have updated the
cef.rl
file and usedgo generate
to generateparser.go
andparser_recover.go
.Moreover, I have also added .ri file to gitignore file as they are intermediate files generated by regel.
Note: I've also updated the go generate directive to use regel-go as the latest version is not supporting-Z
flagChecklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
-
#40348Use cases
Screenshots
Tests Passing
Logs