[8.15](backport #40451) Add a tracer to send (legacy) Azure Event Hub SDK logs to logp #40603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Add a tracer for the github.com/devigned/tab package to route logs from the legacy event hub SDK to the logp package. The legacy event hub SDK uses the [github.com/devigned/tab](http://github.com/devigned/tab) package to handle traces and logs. However, this package is old and seems unmaintained (last commit: 3 years ago). Since it only supports OpenTracing or OpenCensus, in Beats, the library defaults to a `NoOpTracer`, so we don’t see anything happening inside the legacy processor. (cherry picked from commit e64ea44) # Conflicts: # NOTICE.txt
mergify
bot
added
the
conflicts
mergify
bot
requested review from
belimawr and
mauri870
and removed request for
a team
|
Cherry-pick of e64ea44 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
zmoog
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add a tracer for the github.com/devigned/tab package to route logs from the legacy event hub SDK to the logp package.
The legacy event hub SDK uses the github.com/devigned/tab package to handle traces and logs.
However, this package is old and seems unmaintained (last commit: 3 years ago). Since it only supports OpenTracing or OpenCensus, in Beats, the library defaults to a
NoOpTracer, so we don’t see anything happening inside the legacy processor.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
I don't expect the trace to impact users or other Beats components. It seems the legacy event hub SDK is the only dependency using this old package:
$ go mod why -m github.com/devigned/tab # github.com/devigned/tab github.com/elastic/beats/v7/x-pack/filebeat/input/azureeventhub github.com/Azure/azure-event-hubs-go/v3 github.com/devigned/tabRelated issues
Logs
Start Filebeat using a valid azure-eventhub config, and you will be able to read the log messages from the processor and the leaser/checkpointer components: