[vSphere][datastore_cluster] Add support for new metrics in datastore_cluster metricset #40694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
kush-elastic
requested review from
devamanv,
shmsr,
lucian-ioan,
ishleenk17,
harnish-elastic and
niraj-elastic
kush-elastic
added
enhancement
Metricbeat
botelastic
bot
removed
the
needs_team
|
This pull request is now in conflicts. Could you fix it? 🙏 |
…collate-and-address-breaking-changes-for-metricsets
lucian-ioan
reviewed
Sep 6, 2024
lucian-ioan
reviewed
Sep 6, 2024
Comment on lines
68
to
70
| func (m *DatastoreClusterMetricSet) Fetch(ctx context.Context, reporter mb.ReporterV2) error { | ||
| ctx, cancel := context.WithCancel(ctx) | ||
| defer cancel() |
There was a problem hiding this comment.
Since you are already passing a context, is it necessary to create a new one here?
Is it valuable to control its cancellation here?
There was a problem hiding this comment.
We have planned to remove this from all the metricset but not in current PR.
We will be having common PR for doing all the changes related to all the metricsets.
lucian-ioan
approved these changes
Sep 6, 2024
devamanv
reviewed
Sep 6, 2024
devamanv
reviewed
Sep 6, 2024
devamanv
approved these changes
Sep 6, 2024
ishleenk17
approved these changes
Sep 9, 2024
ishleenk17
added
the
backport-8.15
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
…_cluster metricset (#40694) * initial commit * add childEntity * add changelog entry * resolve review comments (cherry picked from commit 83a880f) # Conflicts: # filebeat/input/journald/pkg/journalread/mode_test.go # metricbeat/docs/fields.asciidoc # metricbeat/module/vsphere/datastorecluster/_meta/data.json # metricbeat/module/vsphere/datastorecluster/_meta/fields.yml # metricbeat/module/vsphere/datastorecluster/data.go # metricbeat/module/vsphere/datastorecluster/datastorecluster.go # metricbeat/module/vsphere/fields.go
6 tasks
ishleenk17
pushed a commit
that referenced
this pull request
Sep 14, 2024
…_cluster metricset (#40694) * initial commit * add childEntity * add changelog entry * resolve review comments
6 tasks
ishleenk17
added a commit
that referenced
this pull request
Sep 14, 2024
…_cluster metricset (#40694) (#40831) * initial commit * add childEntity * add changelog entry * resolve review comments Co-authored-by: Kush Rana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here are the following metrics to be added for the datastore cluster data stream in the vSphere metricbeat module. Here we added a new performance API to get more detailed information from vSphere.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues