Revert "Revert "[filebeat] Fix long filepaths in diagnostics exceeding max path limits on Windows"" #40996
+23
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g max pa…" This reverts commit dbbfb5b.
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
mergify
bot
added
the
backport-8.x
efd6
reviewed
Sep 25, 2024
leehinman
approved these changes
Sep 25, 2024
efd6
approved these changes
Sep 25, 2024
|
We're still testing if the revert worked so this PR might be unnecessary. Moving to draft. |
ycombinator
deleted the
revert-40980-revert-40909-fix/filebeat_diagnostics_long_filename
branch
ycombinator
added a commit
that referenced
this pull request
Sep 27, 2024
…g max pa…" (#40996) (#41010) This reverts commit dbbfb5b. (cherry picked from commit 138e43c) Co-authored-by: Shaunak Kashyap <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #40980, which was itself a PR reverting #40909, effectively restoring the changes made in #40909.
The reason #40909 was reverted was that we were suspecting the changes in it were causing Elastic Agent CI builds to fail. However, reverting #40909 (via #40980) did not have any effect on the Agent CI failures.