Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/internal/httplog: log headers instead of request/response #41072

Merged
merged 1 commit into from
Oct 4, 2024
Merged

x-pack/filebeat/input/internal/httplog: log headers instead of request/response #41072

merged 1 commit into from
Oct 4, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 2, 2024

Proposed commit message

Add logging of structured fields for request and response headers and drop logging of request/response using httputil. We lose no significant information from dropping the request logging; in requests there will be an "Accept-Encoding: gzip" that we do not get in the headers, but this is always present in all requests from beats clients. The benefit of including headers as structured data is that we gain the ability to more easily search logs for header values.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team labels Oct 2, 2024
@efd6 efd6 self-assigned this Oct 2, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 2, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @efd6? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 2, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 2, 2024
@efd6 efd6 marked this pull request as ready for review October 2, 2024 04:13
@efd6 efd6 requested a review from a team as a code owner October 2, 2024 04:13
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b s5218-httplog upstream/s5218-httplog
git merge upstream/main
git push upstream s5218-httplog

@efd6
x-pack/filebeat/input/internal/httplog: log headers instead of reques…
a1dc502 
…t/response

Add logging of structured fields for request and response headers and drop
logging of request/response using httputil. We lose no significant
information from dropping the request logging; in requests there will be
an "Accept-Encoding: gzip" that we do not get in the headers, but this
is always present in all requests from beats clients. The benefit of
including headers as structured data is that we gain the ability to more
easily search logs for header values.
@efd6
Copy link
Contributor Author

efd6 commented Oct 3, 2024

/test

@efd6 efd6 merged commit c3dc5a9 into elastic:main Oct 4, 2024
22 checks passed
mergify bot pushed a commit that referenced this pull request Oct 4, 2024
@efd6 @mergify
x-pack/filebeat/input/internal/httplog: log headers instead of reques…
9205056 
…t/response (#41072)

Add logging of structured fields for request and response headers and drop
logging of request/response using httputil. We lose no significant
information from dropping the request logging; in requests there will be
an "Accept-Encoding: gzip" that we do not get in the headers, but this
is always present in all requests from beats clients. The benefit of
including headers as structured data is that we gain the ability to more
easily search logs for header values.

(cherry picked from commit c3dc5a9)
@mergify mergify bot mentioned this pull request Oct 4, 2024
Merged
6 tasks
efd6 added a commit that referenced this pull request Oct 4, 2024
@efd6
x-pack/filebeat/input/internal/httplog: log headers instead of reques…
dd02514 
…t/response (#41072)

Add logging of structured fields for request and response headers and drop
logging of request/response using httputil. We lose no significant
information from dropping the request logging; in requests there will be
an "Accept-Encoding: gzip" that we do not get in the headers, but this
is always present in all requests from beats clients. The benefit of
including headers as structured data is that we gain the ability to more
easily search logs for header values.

(cherry picked from commit c3dc5a9)
efd6 added a commit that referenced this pull request Oct 4, 2024
@mergify @efd6
x-pack/filebeat/input/internal/httplog: log headers instead of reques…
daa8097 
…t/response (#41072) (#41138)

Add logging of structured fields for request and response headers and drop
logging of request/response using httputil. We lose no significant
information from dropping the request logging; in requests there will be
an "Accept-Encoding: gzip" that we do not get in the headers, but this
is always present in all requests from beats clients. The benefit of
including headers as structured data is that we gain the ability to more
easily search logs for header values.

(cherry picked from commit c3dc5a9)

Co-authored-by: Dan Kortschak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @andrewkroh