Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws] Change log.file.path field in awscloudwatch input to nested object #41099

Merged
merged 3 commits into from
Oct 7, 2024
Merged

[aws] Change log.file.path field in awscloudwatch input to nested object #41099

merged 3 commits into from
Oct 7, 2024

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 3, 2024 •
edited
Loading

Proposed commit message

This PR changes log.file.path field in awscloudwatch input from dotted field to nested object.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

The concern we have with this PR is when users have ingest pipelines or logstash filters configured down the line, this might break what they have. For example in ingest pipeline, ctx[‘log.file.path’] needs to be changed to ctx.log?.file?.path.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner October 3, 2024 17:23
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaiyan-sheng? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 3, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 3, 2024
@kaiyan-sheng kaiyan-sheng added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Oct 3, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 3, 2024
@kaiyan-sheng
Copy link
Contributor Author

kaiyan-sheng commented Oct 3, 2024 •
edited
Loading

@zmoog Since we are considering this change as a breaking change, should we only merge it into 9.0 then?

We talked about this on slack and decide to merge it for both 8.x and 9.0 since it's a small change that shows no impact on es query or mapping.

@kaiyan-sheng kaiyan-sheng added backport-8.15 Automated backport to the 8.15 branch with mergify aws Enable builds in the CI for aws cloud testing labels Oct 4, 2024
@kaiyan-sheng
Copy link
Contributor Author

/test

@kaiyan-sheng kaiyan-sheng merged commit 904d14b into elastic:main Oct 7, 2024
22 checks passed
@kaiyan-sheng kaiyan-sheng deleted the log_file_path branch October 7, 2024 22:23
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
@kaiyan-sheng @mergify
[aws] Change log.file.path field in awscloudwatch input to nested obj…
ef9065d 
…ect (#41099)

Change log.file.path field in awscloudwatch input to nested object

(cherry picked from commit 904d14b)

# Conflicts:
#	x-pack/filebeat/input/awscloudwatch/input_test.go
@mergify mergify bot mentioned this pull request Oct 7, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
@kaiyan-sheng @mergify
[aws] Change log.file.path field in awscloudwatch input to nested obj…
2150533 
…ect (#41099)

Change log.file.path field in awscloudwatch input to nested object

(cherry picked from commit 904d14b)

# Conflicts:
#	x-pack/filebeat/input/awscloudwatch/input_test.go
@mergify mergify bot mentioned this pull request Oct 7, 2024
Merged
6 tasks
kaiyan-sheng added a commit that referenced this pull request Oct 8, 2024
@mergify @kaiyan-sheng
[8.x](backport #41099) [aws] Change log.file.path field in awscloudwa…
e4e0a1e 
…tch input to nested object (#41164)

* [aws] Change log.file.path field in awscloudwatch input to nested object (#41099)

Change log.file.path field in awscloudwatch input to nested object

(cherry picked from commit 904d14b)

---------

Co-authored-by: kaiyan-sheng <[email protected]>
kaiyan-sheng added a commit that referenced this pull request Oct 8, 2024
@mergify @kaiyan-sheng
[8.15](backport #41099) [aws] Change log.file.path field in awscloudw…
2a714a1 
…atch input to nested object (#41163)

* [aws] Change log.file.path field in awscloudwatch input to nested object (#41099)

Change log.file.path field in awscloudwatch input to nested object

(cherry picked from commit 904d14b)

---------

Co-authored-by: kaiyan-sheng <[email protected]>
@leandrojmp
Copy link
Contributor

Hello,

The field aws.cloudwatch in the same input has the same problem, it has a literal dot in the name when it should be an nested object according to ECS.

I've opened this issue about it last year: elastic/integrations#5156

Is it possible to apply the same fix on this field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
aws Enable builds in the CI for aws cloud testing backport-8.x Automated backport to the 8.x branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaiyan-sheng @elasticmachine @leandrojmp @Kavindu-Dodan