Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps): bump the gcp-sdks group across 1 directory with 10 updates" #41269

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

rdner
Copy link
Member

@rdner rdner commented Oct 16, 2024

Reverts #41117

Due to

/usr/lib/gcc-cross/aarch64-linux-gnu/6/../../../../aarch64-linux-gnu/bin/ld.gold: internal error in maybe_apply_stub, at ../../gold/aarch64.cc:5407
collect2: error: ld returned 1 exit status
Error: running "go build -o build/golang-crossbuild/agentbeat-linux-arm64 -buildmode pie -gcflags=all=-N -l -tags=agentbeat -ldflags -X github.com/elastic/beats/v7/libbeat/version.buildTime=2024-10-11T13:50:58Z -X github.com/elastic/beats/v7/libbeat/version.commit=89ed20d5ea412ae913fcff6730d3d1304410a990" failed with exit code 1
Error: failed building for linux/arm64: exit status 1
failed building for linux/arm64: exit status 1

on the packaging pipeline that started happening after merging this update.

I managed to reproduce this error locally using the same command (needs to be run in the root of the Beats repo):

docker run --env DEV=true --rm --env GOFLAGS="-mod=readonly -buildvcs=false" --env MAGEFILE_VERBOSE= --env MAGEFILE_TIMEOUT= --env SNAPSHOT=true -v $PWD:/go/src/github.com/elastic/beats -w /go/src/github.com/elastic/beats/x-pack/agentbeat docker.elastic.co/beats-dev/golang-crossbuild:1.22.8-arm --build-cmd "build/mage-linux-arm64 golangCrossBuild" --platforms linux/arm64

when I tried to revert my repository to a25c5a5 (latest successful packaging run on the CI before this change) the command succeeded.

So it's safe to say that this failure is due to 89ed20d

@rdner rdner added Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Oct 16, 2024
@rdner rdner self-assigned this Oct 16, 2024
@rdner rdner requested a review from a team as a code owner October 16, 2024 19:07
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 16, 2024
Copy link
Contributor

mergify bot commented Oct 16, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @rdner? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Oct 16, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 16, 2024
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me. But PR says you require a tech lead to approve. Probably need @cmacknz to approve it.

@rdner rdner enabled auto-merge (squash) October 16, 2024 19:22
@rdner rdner merged commit 9873d15 into main Oct 16, 2024
141 checks passed
@rdner rdner deleted the revert-41117-dependabot/go_modules/gcp-sdks-1e78b9f54d branch October 16, 2024 20:47
@rdner rdner added the backport-8.16 Automated backport with mergify label Oct 16, 2024
@pierrehilbert pierrehilbert added backport-8.x Automated backport to the 8.x branch with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Oct 17, 2024
@rdner rdner added backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Oct 17, 2024
@rdner
Copy link
Member Author

rdner commented Oct 17, 2024

The original PR was never backported to 8.x, see #41203

@blakerouse
Copy link
Contributor

I also want to make clear that this change did pass for agentbeat packaging. https://buildkite.com/elastic/beats-xpack-agentbeat/builds/3372#01927b44-863b-40e0-a241-3956c13efeb9

It is not clear why it would pass there then not pass in DRA...

belimawr pushed a commit to belimawr/beats that referenced this pull request Oct 18, 2024
…10 updat…" (elastic#41269)

This reverts commit 89ed20d.

Due to 

```
/usr/lib/gcc-cross/aarch64-linux-gnu/6/../../../../aarch64-linux-gnu/bin/ld.gold: internal error in maybe_apply_stub, at ../../gold/aarch64.cc:5407
collect2: error: ld returned 1 exit status
```

This building error occurred after the dependency update which this change reverts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants