Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[winlogbeat] Add missing functionality to experimental API #41525

Merged
merged 29 commits into from
Nov 25, 2024
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
9677337
Put data under UserData also in experimental api
marc-gr Nov 5, 2024
d7ae665
Change docs and changelog
marc-gr Nov 5, 2024
f1aa612
Merge branch 'main' into feat/experimental-api-userdata
marc-gr Nov 5, 2024
a4b5d77
Merge branch 'main' into feat/experimental-api-userdata
marc-gr Nov 6, 2024
070ccc1
check evt meta
marc-gr Nov 7, 2024
0213def
Merge branch 'feat/experimental-api-userdata' of github.com:marc-gr/b…
marc-gr Nov 7, 2024
f1de1c0
Merge branch 'main' into feat/experimental-api-userdata
marc-gr Nov 8, 2024
7542c9b
Propagate locale config appropiately
marc-gr Nov 11, 2024
53a195e
Extract metadata cache
marc-gr Nov 11, 2024
f1255b8
Add render config
marc-gr Nov 11, 2024
5662f82
Simplify render functions
marc-gr Nov 11, 2024
cc13d97
Add xml rendering to experimental api
marc-gr Nov 11, 2024
296b5bc
Add benchmarks
marc-gr Nov 11, 2024
d3550fb
Merge branch 'feat/experimental-api-userdata' of github.com:marc-gr/b…
marc-gr Nov 11, 2024
986317d
Merge branch 'main' into feat/experimental-api-userdata
marc-gr Nov 11, 2024
3d4141d
Update docs
marc-gr Nov 11, 2024
383a813
Merge branch 'feat/experimental-api-userdata' of github.com:marc-gr/b…
marc-gr Nov 11, 2024
8c95283
Fix multi os build
marc-gr Nov 11, 2024
d049b71
Format embedded messages in the experimental api
marc-gr Nov 13, 2024
db5a57d
Safer assert
marc-gr Nov 13, 2024
6f9d186
Merge branch 'feat/experimental-api-userdata' of github.com:marc-gr/b…
marc-gr Nov 13, 2024
798169c
Test exp api include xml with same test suite
marc-gr Nov 13, 2024
b5ca0dc
Check for nil metadata
marc-gr Nov 13, 2024
348b85a
Merge remote-tracking branch 'upstream/main' into feat/experimental-a…
marc-gr Nov 19, 2024
1f6d3f1
Revert "Safer assert"
marc-gr Nov 19, 2024
077c56e
Merge remote-tracking branch 'upstream/main' into feat/experimental-a…
marc-gr Nov 19, 2024
5c71a67
Merge remote-tracking branch 'upstream/main' into feat/experimental-a…
marc-gr Nov 20, 2024
66d4f31
Use single buffer to render xml
marc-gr Nov 25, 2024
82aae30
Merge branch 'main' into feat/experimental-api-userdata
marc-gr Nov 25, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check for nil metadata
marc-gr committed Nov 13, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit b5ca0dc3dc94ccaf73091ce646a03db1ddd8da66
7 changes: 6 additions & 1 deletion winlogbeat/sys/wineventlog/metadata_store.go
Original file line number Diff line number Diff line change
@@ -295,7 +295,12 @@ func (s *PublisherMetadataStore) getMessageByID(messageID uint32) string {
return message
}

message, err := evtFormatMessage(s.Metadata.Handle, NilHandle, messageID, nil, EvtFormatMessageId)
handle := NilHandle
if s.Metadata != nil {
handle = s.Metadata.Handle
}

message, err := evtFormatMessage(handle, NilHandle, messageID, nil, EvtFormatMessageId)
if err != nil {
s.log.Debugw("Failed to format message. "+
"Will not try to format it anymore",
Loading