Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16](backport #41580) [chore][metricbeat/test_diskio]: fix CI failure #41628

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 13, 2024

For diskio metricset,

if counters.SerialNumber != "" {
event["serial_number"] = counters.SerialNumber
}

serial_number field is set, conditionally.

This error has likely originated by bumping PR on https://github.com/elastic/elastic-agent-system-metrics.

I think, for such conditional fields, our best case is to remove them from event or else they trigger a failure.

We cannot add such fields at

SYSTEM_DISKIO = {
metricbeat.P_DEF: ["name", "read.count", "write.count", "read.bytes",
"write.bytes", "read.time", "write.time"]
}
SYSTEM_DISKIO[metricbeat.P_LINUX] = SYSTEM_DISKIO[metricbeat.P_DEF] + \
["io.time", "io.ops"]

as that would also result in a failure, because the serial_number can be absent for some devices.

This is needed to unblock #41524


This is an automatic backport of pull request #41580 done by Mergify.

* chore: fix CI failure

* lint

* bug

(cherry picked from commit 56dca4b)
@mergify mergify bot added the backport label Nov 13, 2024
@mergify mergify bot requested review from a team as code owners November 13, 2024 11:51
@mergify mergify bot requested review from AndersonQ and leehinman and removed request for a team November 13, 2024 11:51
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 13, 2024
@VihasMakwana VihasMakwana enabled auto-merge (squash) November 13, 2024 11:55
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 13, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 13, 2024
@VihasMakwana VihasMakwana merged commit 9acb569 into 8.16 Nov 13, 2024
31 checks passed
@VihasMakwana VihasMakwana deleted the mergify/bp/8.16/pr-41580 branch November 13, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants