[8.16](backport #41580) [chore][metricbeat/test_diskio]: fix CI failure #41628
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
diskio
metricset,beats/metricbeat/module/system/diskio/diskio.go
Lines 118 to 120 in bfaa70f
serial_number
field is set, conditionally.This error has likely originated by bumping PR on https://github.com/elastic/elastic-agent-system-metrics.
I think, for such conditional fields, our best case is to remove them from
event
or else they trigger a failure.We cannot add such fields at
beats/metricbeat/module/system/test_system.py
Lines 70 to 76 in bfaa70f
as that would also result in a failure, because the
serial_number
can be absent for some devices.This is needed to unblock #41524
This is an automatic backport of pull request #41580 done by Mergify.